From: Michael Ellerman <mpe@ellerman.id.au>
To: Emil Velikov <emil.l.velikov@gmail.com>, dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 06/11] powerpc/xmon: constify sysrq_key_op
Date: Thu, 14 May 2020 13:44:46 +1000 [thread overview]
Message-ID: <875zczb2oh.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200513214351.2138580-6-emil.l.velikov@gmail.com>
Emil Velikov <emil.l.velikov@gmail.com> writes:
> With earlier commits, the API no longer discards the const-ness of the
> sysrq_key_op. As such we can add the notation.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> Please keep me in the CC list, as I'm not subscribed to the list.
>
> IMHO it would be better if this gets merged this via the tty tree.
Fine by me.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> index 7af840c0fc93..0d8ca5c9f131 100644
> --- a/arch/powerpc/xmon/xmon.c
> +++ b/arch/powerpc/xmon/xmon.c
> @@ -3842,7 +3842,7 @@ static void sysrq_handle_xmon(int key)
> xmon_init(0);
> }
>
> -static struct sysrq_key_op sysrq_xmon_op = {
> +static const struct sysrq_key_op sysrq_xmon_op = {
> .handler = sysrq_handle_xmon,
> .help_msg = "xmon(x)",
> .action_msg = "Entering xmon",
> --
> 2.25.1
next prev parent reply other threads:[~2020-05-14 3:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 21:43 [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Emil Velikov
2020-05-13 21:43 ` [PATCH 02/11] tty/sysrq: constify the sysrq API Emil Velikov
2020-05-13 21:43 ` [PATCH 03/11] tty/sysrq: constify the the sysrq_key_op(s) Emil Velikov
2020-05-13 21:43 ` [PATCH 04/11] alpha: constify sysrq_key_op Emil Velikov
2020-05-13 21:43 ` [PATCH 05/11] MIPS: " Emil Velikov
2020-05-14 7:49 ` Thomas Bogendoerfer
2020-05-13 21:43 ` [PATCH 06/11] powerpc/xmon: " Emil Velikov
2020-05-14 3:44 ` Michael Ellerman [this message]
2020-05-13 21:43 ` [PATCH 07/11] sparc64: " Emil Velikov
2020-05-13 21:58 ` David Miller
2020-05-13 21:43 ` [PATCH 08/11] drm: " Emil Velikov
2020-05-14 12:36 ` Daniel Vetter
2020-05-13 21:43 ` [PATCH 09/11] kdb: " Emil Velikov
2020-05-14 16:46 ` Daniel Thompson
2020-05-13 21:43 ` [PATCH 10/11] kernel/power: " Emil Velikov
2020-05-14 11:20 ` Rafael J. Wysocki
2020-05-15 10:11 ` Emil Velikov
2020-05-15 10:39 ` Greg Kroah-Hartman
2020-05-13 21:43 ` [PATCH 11/11] rcu: " Emil Velikov
2020-05-13 22:41 ` Paul E. McKenney
2020-05-15 12:54 ` [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Greg Kroah-Hartman
2020-06-08 14:38 ` Guenter Roeck
2020-06-10 20:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zczb2oh.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).