From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: roman.sudarikov@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
jolsa@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
bgregg@netflix.com, ak@linux.intel.com,
kan.liang@linux.intel.com
Cc: alexander.antonov@intel.com, roman.sudarikov@linux.intel.com,
alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v8 3/3] perf x86: Exposing an Uncore unit to PMON for Intel Xeon® server platform
Date: Fri, 27 Mar 2020 10:47:56 +0200 [thread overview]
Message-ID: <875zeq6v5v.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200320073110.4761-4-roman.sudarikov@linux.intel.com>
roman.sudarikov@linux.intel.com writes:
> ---
> .../ABI/testing/sysfs-devices-mapping | 33 +++
> arch/x86/events/intel/uncore.h | 9 +
> arch/x86/events/intel/uncore_snbep.c | 191 ++++++++++++++++++
> 3 files changed, 233 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-devices-mapping
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-mapping b/Documentation/ABI/testing/sysfs-devices-mapping
> new file mode 100644
> index 000000000000..16f4e900be7b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-mapping
Is this a good place for something that's perf/x86/intel/uncore
specific?
> + Which means:
> + IIO PMU 0 on die 0 belongs to PCI RP on bus 0x00, domain 0x0000
> + IIO PMU 0 on die 1 belongs to PCI RP on bus 0x40, domain 0x0000
> + IIO PMU 0 on die 2 belongs to PCI RP on bus 0x80, domain 0x0000
> + IIO PMU 0 on die 3 belongs to PCI RP on bus 0xc0, domain 0x0000
> \ No newline at end of file
Git is trying to tell you something.
> + eas[die].attr.attr.mode = 0444;
I believe this one is also known as S_IRUGO.
Other than that, this patch is
Reviewed-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards,
--
Alex
prev parent reply other threads:[~2020-03-27 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 7:31 [PATCH v8 0/3] perf x86: Exposing IO stack to IO PMON mapping through sysfs roman.sudarikov
2020-03-20 7:31 ` [PATCH v8 1/3] perf x86: Infrastructure for exposing an Uncore unit to PMON mapping roman.sudarikov
2020-03-24 20:28 ` Sudarikov, Roman
2020-03-27 8:23 ` Alexander Shishkin
2020-03-20 7:31 ` [PATCH v8 2/3] perf x86: Topology max dies for whole system roman.sudarikov
2020-03-27 8:01 ` Alexander Shishkin
2020-03-20 7:31 ` [PATCH v8 3/3] perf x86: Exposing an Uncore unit to PMON for Intel Xeon® server platform roman.sudarikov
2020-03-27 8:47 ` Alexander Shishkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zeq6v5v.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@intel.com \
--cc=bgregg@netflix.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=roman.sudarikov@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).