linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Qian Cai <cai@lca.pw>
Cc: peterz@infradead.org, paulmck@linux.ibm.com, npiggin@gmail.com,
	benh@kernel.crashing.org, paulus@samba.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Qian Cai <cai@lca.pw>
Subject: Re: [PATCH] powerpc/powernv/smp: fix a warning at CPU hotplug
Date: Tue, 29 Oct 2019 21:13:02 +1100	[thread overview]
Message-ID: <875zk7hnbl.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <1572295467-14686-1-git-send-email-cai@lca.pw>

Qian Cai <cai@lca.pw> writes:
> The commit e78a7614f387 ("idle: Prevent late-arriving interrupts from
> disrupting offline") introduced a warning on powerpc with CPU hotplug,
>
> WARNING: CPU: 1 PID: 0 at arch/powerpc/platforms/powernv/smp.c:160
> pnv_smp_cpu_kill_self+0x5c/0x330
> Call Trace:
>  cpu_die+0x48/0x64
>  arch_cpu_idle_dead+0x30/0x50
>  do_idle+0x2e4/0x460
>  cpu_startup_entry+0x3c/0x40
>  start_secondary+0x7a8/0xa80
>  start_secondary_resume+0x10/0x14
>
> because it calls local_irq_disable() before arch_cpu_idle_dead().
>
> Fixes: e78a7614f387 ("idle: Prevent late-arriving interrupts from disrupting offline")
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
>  arch/powerpc/platforms/powernv/smp.c | 1 -
>  1 file changed, 1 deletion(-)

Thanks.

But Nick already sent a fix for this, I just need to review/test it and
get it merged, see:
  https://patchwork.ozlabs.org/patch/1181275/


cheers

> diff --git a/arch/powerpc/platforms/powernv/smp.c b/arch/powerpc/platforms/powernv/smp.c
> index fbd6e6b7bbf2..51f4e07b9168 100644
> --- a/arch/powerpc/platforms/powernv/smp.c
> +++ b/arch/powerpc/platforms/powernv/smp.c
> @@ -157,7 +157,6 @@ static void pnv_smp_cpu_kill_self(void)
>  	 * This hard disables local interurpts, ensuring we have no lazy
>  	 * irqs pending.
>  	 */
> -	WARN_ON(irqs_disabled());
>  	hard_irq_disable();
>  	WARN_ON(lazy_irq_pending());
>  
> -- 
> 1.8.3.1

      reply	other threads:[~2019-10-29 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 20:44 [PATCH] powerpc/powernv/smp: fix a warning at CPU hotplug Qian Cai
2019-10-29 10:13 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zk7hnbl.fsf@mpe.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=cai@lca.pw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    --cc=paulmck@linux.ibm.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).