From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com,
akshay.adiga@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/powernv : Add support to enable sensor groups
Date: Mon, 04 Dec 2017 15:41:21 +1100 [thread overview]
Message-ID: <87609nxfym.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com>
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
> On 11/28/2017 05:07 PM, Michael Ellerman wrote:
>> Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
>>
>>> Adds support to enable/disable a sensor group. This can be used to
>>> select the sensor groups that needs to be copied to main memory by
>>> OCC. Sensor groups like power, temperature, current, voltage,
>>> frequency, utilization can be enabled/disabled at runtime.
>>>
>>> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
>>> ---
>>> The skiboot patch for the opal call is posted below:
>>> https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.html
>>
>> Can you remind me why we're doing this with a completely bespoke sysfs
>> API, rather than using some generic sensors API?
>>
>
> Disabling/Enabling sensor groups is not supported in the current generic sensors
> API. And also we dont export all type of sensors in HWMON as not all of them are
> environment sensors (like performance).
Are there barriers to adding such concepts to the generic sensors API?
--
Stewart Smith
OPAL Architect, IBM.
next prev parent reply other threads:[~2017-12-04 4:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 5:36 [PATCH] powerpc/powernv : Add support to enable sensor groups Shilpasri G Bhat
2017-11-28 11:37 ` Michael Ellerman
2017-11-29 7:01 ` Shilpasri G Bhat
2017-12-04 4:41 ` Stewart Smith [this message]
2017-12-21 5:03 ` Shilpasri G Bhat
2018-03-13 11:02 ` Michael Ellerman
2018-03-13 16:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87609nxfym.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).