From: Punit Agrawal <punit.agrawal@arm.com>
To: "Luck\, Tony" <tony.luck@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Boris Petkov <bp@suse.de>,
Tyler Baicar <tbaicar@codeaurora.org>,
"linux-acpi\@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI/APEI: Add BERT data driver
Date: Thu, 17 Aug 2017 11:25:23 +0100 [thread overview]
Message-ID: <8760dmpk30.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F61340302@ORSMSX114.amr.corp.intel.com> (Tony Luck's message of "Wed, 16 Aug 2017 15:22:44 +0000")
"Luck, Tony" <tony.luck@intel.com> writes:
>> One thing I missed commenting on in the previous version -
>>
>> Have you thought of exposing the error records via /sys/firmware/acpi?
>> The tables are already exposed there and as BERT is part of ACPI
>> logically that's a better fit compared to a misc device.
>
> That was my first thought :-)
>
> But I got stuck on how to name things. The BERT entry appears in
> /sys/firmware/acpi/tables/ ... but the code doesn't know anything special
> about "BERT", it just iterates over all the tables and makes them all
> appear.
>
> I thought about making it /sys/firmware/acpi/tables/BERT.data, but that
> seemed very ugly (this file isn't a "table", so why does it appear in the
> "tables" directory? So maybe /sys/firmware/acpi/table-data/BERT? Now
> the driver has to make another directory.
>
> Thoughts?
I agree that keeping the error record out of the tables directory makes
sense as it's not an ACPI table.
The best I could come up with was bert-data or bert-region in
/sys/firmware/acpi/apei/.
Though, I am OK with "table-data/BERT" as well.
>
> -Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-17 10:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:56 [PATCH] ACPI/APEI: Add BERT data driver Luck, Tony
2017-08-15 10:22 ` Punit Agrawal
2017-08-15 21:15 ` Luck, Tony
2017-08-16 13:14 ` Punit Agrawal
2017-08-16 15:22 ` Luck, Tony
2017-08-17 10:25 ` Punit Agrawal [this message]
2017-08-17 17:49 ` Luck, Tony
2017-08-17 19:28 ` Rafael J. Wysocki
2017-08-17 20:29 ` Luck, Tony
2017-08-17 20:41 ` Rafael J. Wysocki
2017-08-17 21:39 ` [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region Luck, Tony
2017-08-18 0:30 ` Alan Cox
2017-08-18 2:12 ` Luck, Tony
2017-08-23 14:56 ` Luck, Tony
2017-08-29 0:10 ` Kees Cook
2017-08-29 15:55 ` Luck, Tony
2017-08-18 17:38 ` Punit Agrawal
2017-08-18 23:19 ` [PATCH v4] " Luck, Tony
2017-08-28 20:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760dmpk30.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).