From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933008AbcLIAWJ (ORCPT ); Thu, 8 Dec 2016 19:22:09 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:8493 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932945AbcLIAWF (ORCPT ); Thu, 8 Dec 2016 19:22:05 -0500 X-IronPort-AV: E=Sophos;i="5.33,321,1477926000"; d="scan'208";a="228161290" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <8760muymuo.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Stephen Boyd CC: Russell King - ARM Linux , Rob Herring , Linux-ALSA , Linux-DT , Michael Turquette , Linux-Kernel , Mark Brown , , Linux-ARM Subject: Re: [PATCH 3/3] ASoC: simple-card-utils: enable clocks/clock-names/clock-ranges In-Reply-To: <20161208220901.GN5423@codeaurora.org> References: <874m2jvtmw.wl%kuninori.morimoto.gx@renesas.com> <87zikbuezr.wl%kuninori.morimoto.gx@renesas.com> <20161208220901.GN5423@codeaurora.org> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Fri, 9 Dec 2016 00:21:58 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR01CA0032.jpnprd01.prod.outlook.com (10.164.162.142) To KL1PR0601MB1445.apcprd06.prod.outlook.com (10.169.69.23) X-MS-Office365-Filtering-Correlation-Id: 22ed336a-25ba-4be9-3173-08d41fc963f3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:KL1PR0601MB1445; X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1445;3:Cj8r1ewdcaPn5MknYFP3TBEwmKHwns6pL83qoYX3LiLkX+vxHK6y+RLMMoHQQc/oTFI3Ws3YJg0LaXci5WmsE0D1FqEMBoP89YwkZzL+JxVKiudsn1PyPK4lvlTOH2elf/ZDt++PqdxrJyP9BiK/MnGaspYwiWaCcXb38dHbmz+cq2bjwYc+aOytxDWfNxXvOiGHUNSDT6wqYXKO/HOz7lZmOKaW4ZGDrYgj9PybJ1t/mFHSTkFR7/SKFLUQOzrhxk4xywgo55plf86kWwviYg==;25:Rcxm++PTV1VdNUq5dhRm7M6OMYnwlumvPyaFzrdpRiSUCJfpQBBhCfvs7tPmMIcdmFyGjLW9fwrnc23Fjpi2qeRUq7ioNsqLdj/YbovU+Me9T/G2tCm40DueJu7NCZRSQDfE9OM/utDZYhh9Bfeo10f0us2uDb1MFdIS2V96e4qmcGo55TGN4W7psdjWjJhZCuNPlXBCMmOe+VUuvPyrMaCT8y9n5DqrqXiwwS1vXDNjn2FRb3GlqLFG47Tni9mdJOayEAUP4H+1D4gzfAZjqCxA3/GgYOpUlay/95wVspuLsANa0JdGYrGR1ysUnfMMPVsouYI4U4Eh4iXqbkeXfi81UE6w9FoO69Ty5HO001ae79DtnRybKoz1q+YuGC75mTh+iCylY/wsDBkvq6lR3L8czRYD50VpfpoOwBW5aOFS0hrJVPDScDdkIr1/3LZeKnwke5/+kz6izVOX/OwBmw== X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1445;31:u9O9caGRXjfYtHpbXb5a2vRWxna7L7lDnUDBJ15W7exSG+8UJkLQK8Wi6Uepp0XS5KCMR1w9c7MRMHd6X+6m4x8xVN54gmO7GyVkuNIksL6Y0UPdX+dhaNGukFgGR1v3eesrbp9xLVW4ZxsCoP/ImoOJ9Np/2t+24N+t4/Xw+lAs8GoNH5lonVhqxD38wX1sv7SRIgAVk4bHllNn2pSNf9m9mjBdv5xWvuH6XuR5lAAQp0Nbz2Qvmn2wUc+LFfNOranBdIUQSI2BINYdup154np5nGs7g+vT2ZDG6IjGquY=;20:VjKXzE2k086eeUMz/GXW52dgD1Y63bR6qhuaBYF1zGslgQntEo333+Nl8aOfdz+xHcGW1t0022lMEkygrxow+XQexl4mSkNB6+o0vV0VW02t1P0C8xsQDay0CSE7TghvLVWbdYS+TH06TItPZuUO2VG+gn5lVVfP1L6IZsdR8N+A28CNmvdeW5JY89ewnc2wQvjRBBFkTHaHoSOVsq1Vys09E6nY96Z+yqHB3eBevCw2G0Y7U/M6NbKlCHQlRasNl1J0/scB2n0OzH0h3ylhc1WH+wRigYGgr9KvO2nEbRiPDGFuHOZPBZxLTxKwcn19mFbjAXtHBNcpt6O+22NI5Br55PPk9bnomDSqw37IllYf6yMFAq9pjLLWfpCV9b0gP0b2b64UxBMJK4A6Y0OxYCSJGUrlWrpusD4dgWDwVZrk9tYcPdO6yiiC4ebKZAm+mMRaNv5DIQiGTFyg/RwuzHyRAfVQmruoV+/EHlxBs+5DrqXtm5B/pHdRXNv0Qufn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(6072148);SRVR:KL1PR0601MB1445;BCL:0;PCL:0;RULEID:;SRVR:KL1PR0601MB1445; X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1445;4:TUfPPE+8ylO/Nno9QeD0lBHvEOekZZTmTMyi+uEofiI0obDVVA0fu2TpwCF9I9Xrq042PP+KNN72Nq4YLl6sWrvtdwS7n7K8FZ8NRjEy3FI6obHD7S9n21CWmHn6GA9XeqndQ939iNErWaXxGplqXXe8moKQFRFYw94lqn4sX4LgazdVEwP0HPZlzROhcNBDo4yRykF/jwTsCKUshgoTr9syClNkyh/H/ueq5CHl3aabL1OxGNn2X8RMWBZOoCf2ubjTqMk+7xZ5OlD4MFbwLFX+lO92HNWufUxxNqcLJmXFgyRRVypH4hfFxG4qQDm7ZcvJRnybwewQy329w7UnEq4Zpo+4bIaVFKbisGHwqxHEJvw5xsT0xugbki2mwPqth+iFD8FZBETOJ6PNum3ZJWR5BeiTL2zM4KpTmNQoVICITaOo7TPCLQ+aFhCurn7+yv9Fdzzwx7/xphNWkpv1SiBdNMQFVDbDvjB7tWQtpHCNyRDmyy9yM0kX2EOkFNH+lg4UmduPpCXM0UUro3vnvdd8M6zLQnd6cqMCd3bocvDOzjhb9YuAw9Xi24DFH2zCbotsA2v+59zoELJyDhrrHg== X-Forefront-PRVS: 015114592F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(39410400002)(39840400002)(39860400002)(39850400002)(189002)(199003)(3846002)(6116002)(92566002)(4326007)(8676002)(36756003)(69596002)(733004)(23726003)(6486002)(81166006)(81156014)(38730400001)(86362001)(53416004)(229853002)(7736002)(33646002)(305945005)(106356001)(42186005)(105586002)(47776003)(2950100002)(66066001)(230783001)(46406003)(68736007)(189998001)(5660300001)(4001350100001)(110136003)(76176999)(6916009)(97736004)(83506001)(50986999)(54356999)(2906002)(7416002)(101416001)(50466002)(21314002)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1PR0601MB1445;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;KL1PR0601MB1445;23:b1WJln5sHYqi4lxTy40xuz4buD3vdXQpDk5zWrH?= =?us-ascii?Q?G+GzIOzjW7x2Vbm6g3jzMyjwCTGCI6czGjGwELPfU6rRICawM6A4NIFRdgDF?= =?us-ascii?Q?nAmW7QwfuMXCsf+Vf6W6StSNCfh+FPGGuf92l2zD+ZYR6H4aA51Iots7MhhM?= =?us-ascii?Q?3U0ahD+PogYyGESyWGb9eStB6a9esAAutsdDVrw2cziS+kYWQH5OqPKX2Q4A?= =?us-ascii?Q?Kb2pEYA7jYBkRBFxTE1LWfHviMsE27cWDAp8O1bO08XZH/fqIV2fyBOlVm0q?= =?us-ascii?Q?OJXMFOY6nNKEm/0K4Eu9W/Jg8EiTpeudeJ9bLZvgK/0fD/pB6ffusLwRnygR?= =?us-ascii?Q?5icIyO/nwimhHGOBVVGHub6W69uSZc7EcdnXHhvPP7LKOMhEH9cT5/vhHTxx?= =?us-ascii?Q?1hhFVD+P3KGcQ/5TiR3B5AUzaVdLnd5n/tGJVaPGd7/lWj38b1GhNFVyw56F?= =?us-ascii?Q?/ZUh3r0sn0Am9ZysDonVfOUh3Gsm+kd91k2MwwJtJmB7fTrCWJw5AXpq7Hu2?= =?us-ascii?Q?3jXLgRn9rA1w2yH3XmTh1meGEfi+gRM0iON1dbrVl1mWN3YGn1oj73lzkMuj?= =?us-ascii?Q?j6lCWNX1SfdioX6vT6BXZk3PUsASfyJQ7ouKELezgrgwk4avlpVJrQlIBknQ?= =?us-ascii?Q?Op9hixmzBOW3UAzqdSD9cxzlo+u8mzNqFX7MOI+9e4OKpmYAbJnnRmJ7FpWA?= =?us-ascii?Q?ja7S6aFGOt3bct4XWM3awB4uZcM60/HdJ3S7ocB5LKh+OCjW+IOs4WPBBYb2?= =?us-ascii?Q?mvHnW4/3aXzK30gPujcsv3cjydWsZkQCRaEH9L9Q2SaCegZxtkgIGONANLO3?= =?us-ascii?Q?VzJiCbHRi4xI0vcbCU2XR0y67+0QXZr6CAjdFZ1EcLYcvTqKFlp++X6wNfkR?= =?us-ascii?Q?YtYlmM6y9OPbbYND+zty2CvQh9rkYGHiqEe/xp0SHeHVOVTo0ciTwPKABjO3?= =?us-ascii?Q?wsPZvkGkvrQiSoTMolF28gXMcQGThGej2Wu7rgyDsSLeTV7A9A03LWMlZosk?= =?us-ascii?Q?2IyYfrwDDmpjxQKbGsmO33FgqONUeE7gPtbOeneTQ/LPxeYSPeoPywsmaVUM?= =?us-ascii?Q?LrCyzPd8n33aH5BukpvNsIjEvaLsrGnNCR+7CkNfdEVaRBQEsjRyCQrrrBF8?= =?us-ascii?Q?H9C3ObvW6gKwps8eTytJBfFVl0D9XqnxcA0eq8VByvySoyxceofI/jiW7++I?= =?us-ascii?Q?f/7pRG3D+aih7m7Yjc7VOocikj1MPk5E3g9qmx5wAY+4Zqcivj7hDzS5JSTk?= =?us-ascii?Q?Sq9NeG41lVfOy5c78qA7bc2mbBZaiKskUhe8NBS4zpU/4EdCM8KGvg/PdECO?= =?us-ascii?Q?mysOIGI9l/PqX7yLxwz94vyE=3D?= X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1445;6:IbReWWhGjO4vgsRcYvdFQ9kBO0kcKnGEnRQFG3tWA47RYwSgQE1Z6cqhCnQLHBrH50o4N2dC7B/WMPQvQpiWvlam8MsVHZC4nrVpTADvhgzFwFImCpZPVYaFOgwjcyrAATx8sq2P8m1yf+LyfGmd43hEkDSSmi83Qotw+E5xNVoDHhdshsZVLnQbpvFT/anu86WuMD2IJq7SuAAeBoygNe0KpAWueKA2YQJyRDZa5C4wc2DKV3gPIvwooX2xh+Tvd7L61GEhPAaedkv4yYgNcDxPpnNqSpO7VYR7iNVPBMcoECzrZGhAXbk9BuzBuAyDKwq9wSYVbZOEVlKO7/vQyfDDy4tg5342w8H4j9Q/LXp3RcYw8KzRKq8LfEpwbvxPiJHKyBP1p1QtqNNpjv3nWbiHySKHNf5qN0oJVA9anoS6CnVHvDNM0/ycYzW/i4UGNhNc9nOvV3KTufyytxoDVsn538RaTC4VeJhsuTanKgM=;5:UGSSci3M9FI2WrnAVgmOBhbUaWFrvVbq5fUbaKO3hVvBiNg5MX91F4943evgc03GaMsK6kDCkUclfKcNtDIYWRsQfEWKiySSH3+fo+UqHy8yBeks49bgo7N4EI32qRqTsNY/VdjNeLYeeR4NFA8+Yw==;24:0GhMsPRLjwb8MsIjTWMfxOqCnm2AXghwA5tfNw4cM+lrqBWXTgtLVacURsSkNb6/N0iiKB4PASgp5TWiVH75HQF+PhhVnl3iqyKcxY8BOIE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1445;7:Nm31J3+e3B6Uf7UaOvLaIJ9gBy+QL0IuUvhVowWUlvE32/5M9YQ/iFixp4U90U14Je+vCqs519rOecgCLN2kpAWiTnTje+owVaWR+DYQ5XSAG12Y7B1F6SFB2tVkfVexkyrDmn7jET3cIWiTfMWFGpRcMZ7CoKMX2v/CzI79SBl2RKM626zOCEdtQj+5gcBKxNowwjwIF4BFa9gwLARAvlDP3EvwC1nYi7cViZFHqLz2WuwaTz0+Iq+c9jTq96zve0loBedCtZw3d7j6qnlgnaiHWopsO2WiYw0yAUkfS5tL+Fj7GzE7cYXTaqPQOxrL21bC5KOq4063a1xIt1GLueA4+JVxkWgR41wcgjnK3d7wykIvS3T6gdrCmgPF8Y7hN6Iw+yQ4FsRXVEzeLdTBMGDiGWJk1SMYbESlBmsefS9q1PAvbZbOcjxiJuoMzTam2HZHqh1Wl65iPg3X9UOoGg==;20:r6LJhhpm3E3Mp3n+ck7VKS5GbhzlG8Cpnrt5qE/SNQi7JSzTlmXuwfH4ExTQOL0yvfFOV8PuAoI2Lx58Tyhe+B7OHkn8ayTfPsMrQCkSHQ+JLxwPcNABN0gqHkFGzmcn66woXHC7EIqfW60Fpqjp0xEoqoxQrgZnJNn86Crp4GE= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2016 00:21:58.0892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1445 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen > > From: Kuninori Morimoto > > > > Current simple-card is supporting this style for clocks > > > > sound { > > ... > > simple-audio-card,cpu { > > sound-dai = <&xxx>; > > clocks = <&cpu_clock>; > > }; > > simple-audio-card,codec { > > sound-dai = <&xxx>; > > clocks = <&codec_clock>; > > }; > > }; > > > > Now, it can support this style too, because we can use > > devm_get_clk_from_child() now. > > > > sound { > > ... > > clocks = <&cpu_clock>, <&codec_clock>; > > clock-names = "cpu", "codec"; > > clock-ranges; > > ... > > simple-audio-card,cpu { > > sound-dai = <&xxx>; > > }; > > simple-audio-card,codec { > > sound-dai = <&xxx>; > > }; > > }; > > > > Signed-off-by: Kuninori Morimoto > > I don't see any reason why we need this patch though. The binding > works as is, so supporting different styles doesn't seem like a > good idea to me. Let's just keep what we have? Even if a sub-node > like cpu or codec gets more than one element in the clocks list > property, we can make that work by passing a clock-name then > based on some sort of other knowledge. OK, thanks. Let's skip this patch. But I believe this idea itself is not wrong (?)