From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933422AbcHBDWY (ORCPT ); Mon, 1 Aug 2016 23:22:24 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:54534 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933279AbcHBDWQ (ORCPT ); Mon, 1 Aug 2016 23:22:16 -0400 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'208";a="216959913" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Kevin Hilman CC: Liam Girdwood , Mark Brown , , Sekhar Nori , Jaroslav Kysela , Takashi Iwai , open list In-Reply-To: References: <20160801233610.10479-1-khilman@baylibre.com> <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Tue, 2 Aug 2016 03:22:08 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR01CA0127.jpnprd01.prod.outlook.com (10.167.154.45) To PS1PR0601MB1449.apcprd06.prod.outlook.com (10.165.210.153) X-MS-Office365-Filtering-Correlation-Id: b409ee7f-e760-419f-3447-08d3ba842fe6 X-Microsoft-Exchange-Diagnostics: 1;PS1PR0601MB1449;2:uuSNxrffi1oARy4FNaVSKZrH4jzwbK/AEOhGGB310HBBtyXXStua68Q0FMS/LIINyxaT0LbUBVfpjs0HqxBuqIv9IOdXUbzB2BVc4+qPmVO1bG7ZuXGHPKe5/B6dg0ST3ihQnCHMpNwsSI89h8x780+9WaBTLf2nZajN9eA+ILjk/6OqGSCgDwv+D530ZR26;3:JMqrEAcBBQCV0t2NRK+ugOi3owCguXQbkAEBnwVChreSYifVzqRQ36G00csHjcL8Em/UZyvoDY0R+/QMzwwWOTMkOTdJHreNS5BZdypMWpcKVLCG5zYVu7gz0cwZwmTR;25:tJdFkh02Bv07UMJO0n110pZo0fZM1uf+ZK0b/T5S3gbew9ShxlOQoaVCh/SGfL3foXn8TvwNg6GuXQrxM6RZdCtngwhfZRfjnofSD+sSd7Csqc6uXMhd36LyeOgNZeRpDa3AzEz8OGf4JkpKyLpgb73Rgjn2fVBHw1MmV6S9opAwG5yv2woqYEsA2w2eSr53SxvPWL8enBL5C9pWxClRKikw2qASIViWM1p8XLqRt2dC2Qa5u1OWSGLui+rbHmDdKTRN6XXtDpSXvNDHSwzg4jlevQk6ADtk1jjmoIp80x78zZPYSCoX/imv39SRCIV8mm4YhMBP9lMsWK641X7aQItrBWZqUOCHE07D2XcK1Bf6dkmaxZBxhJ1x72FEtaTAoOVNMOrub4mmIG+8+BIpegT0NGSK7nsUfq6DIEp07f0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR0601MB1449; X-Microsoft-Exchange-Diagnostics: 1;PS1PR0601MB1449;31:qVCup8/htoSoKW+kqESmZVy5XzX420lr9D+Zzr9Y6FdSynpeFuqwMvJBUr/c5x3cRiiRO6oxgQgw4kAbJ2FRYx+YAH4MJSL6ete0/i/vJQ7qy3B5PmCFwBJIOpQc/9/8ID1mx3nMplLnWsV8GfHg6ih/DNpPqpuI3Er/SqWqmc+c2yz3nbWVC2UvTa+ehlB/BxIpQ4CS0EQzh3xe8gQLMVrT1YnoFTbx2kPzQ7mpaKA=;20:/ofrRHxG0mFgZFJH3e/7kltg0OFKvUrMCLg1BV8eypDtOZv2nJS1UjgJn9gfqRTODjGicJqm1hO2xoj5xhewJtBXQud2JAnkC56dZ3RvdoU2lc9wDcJSOkzq9hhd0rleW9N3cv7WJRZ3Aj+1rLNmg69Oven0hG5/6sBnyUiOeCjDshPq4bOPVPhQreE34G+RxstSs3QcStZkSJc43lKlyVzK1XysZu5D2LaZrse2pFD/4IGKdCpdAO394Ca5vWMkbFf+Gpr7Izwb4MCvqmUKHu1iAT/IO6oSpMPRSsiWuMmYouGrV/7E69Y8N72kQhngHsO1jWTG4q3Iu2E3doBslPBB6jV+0vcPd71RI8ECdg/i2l539d3I/5KL2BQg/soNeq3fbClJAsF8reJ/R+c50dK0XioySKp84gYxnZxI6gM4diTah96uOIMRshT2bgNVEZetGc6ncsy35HRtDb+1CfZk8DRS20CQzdZWhP0mO8+e5lcwIrHy0CU4P7vTr1gh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:PS1PR0601MB1449;BCL:0;PCL:0;RULEID:;SRVR:PS1PR0601MB1449; X-Microsoft-Exchange-Diagnostics: 1;PS1PR0601MB1449;4:w+ghQvXzZedZwUDFPD1i2HHyMF55isSChRcvbdIyK0jSLVt8+x/DIqWKqoyGOvLI72FjpQX3uRsnW7U/DDXlgtwj+HG7tWT11xfRRTTX+B2UTO6J8ltEp87iYzny/U6JowOBBr9mgF8OHgC344afyg/bLmfwmFZxIuE3yoy3GDGVgayHkFt5KBnkWEGHK3d1CvIrqPZkCEEjEE/RP1xbqCLclql8GLsruh38RFW/FPEaQSfEscWFQg1v+Zd2YSDz896sojTMdxdS1XnhZ4qbfGgZ5oJomm3lY51Vtm+UTy2jviQ1dGXEtzPpDZM25qK7ncxLmYGFyAD28Vjn/r+U0hzBhO7FDJjH8ZEse2YzS88GKTAsXsvSuAz1+N6r7V/usVia2pxeoPh1Q/ftzhd4Yw== X-Forefront-PRVS: 0022134A87 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(230783001)(110136002)(105586002)(77096005)(42186005)(69596002)(101416001)(81156014)(68736007)(4001350100001)(97736004)(83506001)(81166006)(66066001)(19580395003)(19580405001)(47776003)(586003)(345774005)(8676002)(229853001)(7736002)(6116002)(46406003)(3846002)(2950100001)(575784001)(4326007)(7846002)(92566002)(305945005)(53416004)(76176999)(50466002)(106356001)(36756003)(54356999)(86362001)(50986999)(189998001)(2906002)(33646002)(23726003)(2004002)(21314002)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR0601MB1449;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;PS1PR0601MB1449;23:a2uPUUKYcIlmf/Xs9F+XdR9Jb7vLTMTfIIxHT3z?= =?us-ascii?Q?h1StM6JERyd/m1Z6K6mP/pTtA10EhFIZYCXTG4FhFMCpvmOpE8KzX/RqUJKg?= =?us-ascii?Q?H9hXZM4U1aexTe2sl5scBh/FHDcgvmmtVW2C5aMr7zljjbEHaL9fYLfFrQql?= =?us-ascii?Q?9jAQd/U/95635yi8cL+7ZuHrkUVf2N79qdnKUEt+YwVjS93XGGdMQ3uVgaVB?= =?us-ascii?Q?rGJstXTLkb/Y5gWDep0sc6kQq8PXXcCg1Ovmw94qRx/NFBiRpWZFnmREVXn1?= =?us-ascii?Q?Dev1JyEywaNDcQYDZiu7FPMC4dJMMkuzmrGMvOJpElrzHa1ffowpF5uFxVh1?= =?us-ascii?Q?bZ4N0e2D/jPvMf23C8xYBps2mfafyPblBFK2BSSEF+oh0oauvlojd/MBklED?= =?us-ascii?Q?OffpNJzL9zEtfyp/u9xh+TczdzF8ZdFCC/soSiwOdY2Hw6GvvPorZjUSnY+R?= =?us-ascii?Q?KRvkVR1G1OGjWTw8MpdxQGzjSZ4TUFeRpOGkfyIgEjY2NuYnV8gfLq9hA6FR?= =?us-ascii?Q?Z+mNxnfO5jndiah+42Z7Z8LKMJXD0+KZ7Knk3VSmpWcge4XtN9Tb08SYctUf?= =?us-ascii?Q?xvFvFucKhzc9PnvBpp7+8UrSHa3vhTqVz6ld8xpS7uZd7eBz4TROoma05N9R?= =?us-ascii?Q?jbfidfH48L9GQ1Kd6E6UXbrRxSTrRKyfircDTUHF2Xx55An1cjWnN3OfyVQ6?= =?us-ascii?Q?uwkFIFPsOroi7U5xx0jJPuvnY3cTBENs5+1O0oYxNEE5qDl6MH4Dmo9C7o98?= =?us-ascii?Q?9SSVMpUCJEDiwUXq9FT5wNRUC89Hvz00TIgNfymMnieI+0U719VJKLd92fUZ?= =?us-ascii?Q?yGN8sMlQK06nREp3KvPYe0TyKa2g4UbKqSx1GRPzuCB3yLKWazQk7WwuOLg6?= =?us-ascii?Q?b527UBn0CkOE7EhveG9sfX/2H8Z99JKsk8yLFyOnajjDLQMz/MPYH79xNZQc?= =?us-ascii?Q?K+Bl4oq2/2xyK+/ebaublS0Tj3BG4930Q168npGpOtos0uGVqG1tHs6Crucv?= =?us-ascii?Q?uFo30Z1b0BNexXU2rJAlOauRApWn1fc8YRr0cmAMsBvvKRjezCiBcy5CaYqd?= =?us-ascii?Q?qASOfH8ieKCe57O9G5pcH2iLRlC7qfdY/+JJRgSB9h5lObikFRK0gF7Yc5xe?= =?us-ascii?Q?QvJVUWHAmtEFedAr6vgekbPhahNrfJEbGU7lJpXujnx8JalRPFgJ+fcdngy5?= =?us-ascii?Q?AJII5RqF3YI/FT680s16wKAmiilpWvJI/fUkqCF6rLKcIzLfFNr2kUNfRixU?= =?us-ascii?Q?/0tBSENX8FXsV4/IPO7pTsV+AR8AFD10t1bZ4Xzxy?= X-Microsoft-Exchange-Diagnostics: 1;PS1PR0601MB1449;6:LBV5KuYIkBAn6twgx9qqOM1GPvYxKD83WA1zbforjY/n9jPaqA/otpIwSZ++7R323HpkCkoQ15VBozUJQ049tf72Sf0MzxRhlPb6ZdE1caY9o5YzOcvjyRxs+iCndlwD8+CVipNA/jOF4Uypjsy3w2oESv13/yLvrkUvh6GoXnDJ26C4za3MkPluyTQwvFOV+qyzQ4VJSj4Kqu/+ox1sDDkavyfwS9vhoR82JnH4vXaJnBMm88tYMEgDJGEKsq/pEIulG3Xngkek4exCYPDCDwzOjBI5HUyn5Kg3YEXqE4obL6ccVynvvY6Vnlnlk95i7ldiDsd95JQi/9jxndRrJA==;5:R/UIMHwzlytyy7njPWllq9DYWcXKRxUQCQZXZzwAtHXPlJ6t6XoI9gv+Fd4AHpW14Th3ukcnViThzyGE+SrzOANzuA6EyYtip9xZrNHdFg+b6zfQoKbaBvty7bXnH21v0AXfENJomzQGxJFEAVCBUg==;24:h9VfhJUQddfC9qLo9blnsK86L8KwnFWvTBDTpx1JWwmwVfbNS+wkwJYamDOEk0UW29N8MuT8ea4KhBsgMxV68q2OycFlcxzuHDfJ7E3YccE=;7:9G7nfIC8o3pbnXQoIUmNsK6hVD9hH+AXg0uXdi7e0qmW2XnRUxwnvb+HbwNkned+tcDMDSbSAv9WpDd3iWxyxPhr0JLJDRIFUrEHzt+nxo2NHeO2lgiX3raJXLRG4BK8lHTcOTBj8MvKRVqQvfVhbbwKYFiP4NCh0tGu9HyIRsIxXVRAV1RqFZF2gTzpeWsKFlRBEOoEzydDHNygGselmOX5YScVQh13/9KPvpAe1v1Zk8WuXmNRn10C1ELx6kl+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;PS1PR0601MB1449;20:dS01Agr3J1XCIEO5Y9irZnmTBWbDeBx3F4iQvhlBfz2zlvSRP6eLY7JQ9a2NEIWs3IitY0VAmCM0K6DMNL1RDzzZVFkSBbA5eyWF9Zbc/JGNJLHmpyrQtuqNeIVP4Tu0jdNWIYk+AgXBypnlzz2VRxDKyln0m2sekN66IC2e1yY= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2016 03:22:08.5812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB1449 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuninori Morimoto simple-card-utils might be used as module, but MODULE_xxx() information was missed. This patch adds it. Otherwise, we will have below error, and can't use it. Specil thanks to Kevin. > insmod simple-card-utils.ko simple_card_utils: module license 'unspecified' taints kernel. Disabling lock debugging due to kernel taint simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) insmod: can't insert 'simple-card-utils.ko': \ unknown symbol in module, or unknown parameter Reported-by: Kevin Hilman Signed-off-by: Kuninori Morimoto --- >> Kevin Thank you for your report. I think this patch can solve your issue. Can you check this ? sound/soc/generic/Makefile | 6 +++--- sound/soc/generic/simple-card-utils.c | 7 +++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile index 45602ca..2d53c8d 100644 --- a/sound/soc/generic/Makefile +++ b/sound/soc/generic/Makefile @@ -1,5 +1,5 @@ -obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o - +snd-soc-simple-card-utils-objs := simple-card-utils.o snd-soc-simple-card-objs := simple-card.o -obj-$(CONFIG_SND_SIMPLE_CARD) += snd-soc-simple-card.o +obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) += snd-soc-simple-card-utils.o +obj-$(CONFIG_SND_SIMPLE_CARD) += snd-soc-simple-card.o diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index d89a9a1..c0a726a 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c @@ -7,6 +7,7 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#include #include #include @@ -95,3 +96,9 @@ int asoc_simple_card_parse_card_name(struct snd_soc_card *card, return 0; } EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_name); + +/* Module information */ +MODULE_AUTHOR("Kuninori Morimoto "); +MODULE_DESCRIPTION("ALSA SoC Simple Card Utils"); +MODULE_LICENSE("GPL v2"); +MODULE_ALIAS("platform:asoc-simple-card-utils"); -- 1.9.1