From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751763AbcFWIVv (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jun 2016 04:21:51 -0400
Received: from mga04.intel.com ([192.55.52.120]:48949 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751023AbcFWIVt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jun 2016 04:21:49 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,509,1459839600"; 
   d="scan'208";a="1008006666"
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
        "dri-devel\@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs
In-Reply-To: <CAKMK7uG-J=nx9xTdNbF4PBMYPpatRFVgdY-74CZ9EjmtE4gSRQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <1466507202-23222-1-git-send-email-tomeu.vizoso@collabora.com> <1466507202-23222-3-git-send-email-tomeu.vizoso@collabora.com> <20160621150758.GB21079@ulmo.ba.sec> <CAAObsKBUaJkw=DRD4JUDmfYJ9a0OAUc9TbAhr=8C5sTi4BL_8g@mail.gmail.com> <20160622133216.GL26943@ulmo.ba.sec> <CAKMK7uHu3+BM=cn2GiniTCd_ML9QmpvC5Gj9MKn9LvMK69b0YQ@mail.gmail.com> <20160622143144.GN26943@ulmo.ba.sec> <CAKMK7uG-J=nx9xTdNbF4PBMYPpatRFVgdY-74CZ9EjmtE4gSRQ@mail.gmail.com>
User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu)
Date: Thu, 23 Jun 2016 11:21:45 +0300
Message-ID: <8760t0jox2.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 22 Jun 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Jun 22, 2016 at 4:31 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
>> Perhaps another way to avoid that would be to put the two files into a
>> separate directory, as in:
>>
>>         /sys/kernel/debug/dri/<minor>/crtc-<pipe>/crc/
>>         +-- control
>>         +-- data
>>
>> That's slightly on the deeply nested side, but on the other hand it
>> nicely uses the filesystem for namespacing, which is what filesystems
>> are really good at.
>
> crtc-<index>/crc/(control|data) sounds great.

Side note, we should eventually do the same for sink CRCs, but I guess
under the connectors. i915 currently has a special cased version for eDP
(named "i915_sink_crc_eDP1"...), reading the data from DPCD.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center