From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932148AbcCILt1 (ORCPT ); Wed, 9 Mar 2016 06:49:27 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34714 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbcCILtV (ORCPT ); Wed, 9 Mar 2016 06:49:21 -0500 From: Kalle Valo To: Rasmus Villemoes Cc: Kees Cook , Andrew Morton , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/7] wlcore: avoid fragile snprintf use References: <1457469654-17059-1-git-send-email-linux@rasmusvillemoes.dk> <1457469654-17059-6-git-send-email-linux@rasmusvillemoes.dk> Date: Wed, 09 Mar 2016 13:49:12 +0200 In-Reply-To: <1457469654-17059-6-git-send-email-linux@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 8 Mar 2016 21:40:52 +0100") Message-ID: <8760wvswg7.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rasmus Villemoes writes: > Appending to a buffer like this is not guaranteed to work (passing > overlapping src and dst buffers to snprintf is undefined > behaviour). The standard and safe idiom is to keep track of the > current string length. > > Signed-off-by: Rasmus Villemoes Should I take this or what's the plan? -- Kalle Valo