From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751681AbbBPX4S (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Feb 2015 18:56:18 -0500
Received: from ozlabs.org ([103.22.144.67]:46214 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751277AbbBPX4R (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Feb 2015 18:56:17 -0500
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Dave Jones <davej@codemonkey.org.uk>,
        Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH] module: do not print allocation-fail warning on bogus user buffer size
In-Reply-To: <1424085783-200431-1-git-send-email-kirill.shutemov@linux.intel.com>
References: <1424085783-200431-1-git-send-email-kirill.shutemov@linux.intel.com>
User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)
Date: Tue, 17 Feb 2015 10:25:48 +1030
Message-ID: <8761b1tnqz.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> init_module(2) passes user-specified buffer length directly to
> vmalloc(). It makes warn_alloc_failed() to print out a lot of info into
> dmesg if user specified insane size, like -1.
>
> Let's silence the warning. It doesn't add much value to -ENOMEM return
> code. Without the patch the syscall is prohibitive noisy for testing
> with trinity.

Heh, we used to have an explicit length check because vmalloc would
BUG().  So I guess this is progress...

Applied thanks,
Rusty.