From: Paolo Bonzini <pbonzini@redhat.com>
To: Barret Rhoden <brho@google.com>, Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
zwisler@kernel.org, Vishal L Verma <vishal.l.verma@intel.com>,
rkrcmar@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
KVM list <kvm@vger.kernel.org>,
"Zhang, Yu C" <yu.c.zhang@intel.com>,
"Zhang, Yi Z" <yi.z.zhang@intel.com>
Subject: Re: [RFC PATCH] kvm: Use huge pages for DAX-backed files
Date: Tue, 6 Nov 2018 11:19:18 +0100 [thread overview]
Message-ID: <876d5a71-8dda-4728-5329-4e169777ba4a@redhat.com> (raw)
In-Reply-To: <20181102163254.04be68b5@gnomeregan.cam.corp.google.com>
On 02/11/2018 21:32, Barret Rhoden wrote:
> One of the other things I noticed was some places in KVM make a
> distinction between kvm_is_reserved_pfn and PageReserved:
>
> void kvm_set_pfn_dirty(kvm_pfn_t pfn)
> {
> if (!kvm_is_reserved_pfn(pfn)) {
> struct page *page = pfn_to_page(pfn);
>
> if (!PageReserved(page))
> SetPageDirty(page);
> }
> }
>
> I think we want to SetPageDirty for DAX, so making PageReserved be true
> for DAX seems like the way to go, or we'll need more KVM-specific
> changes. Apologies is this was discussed in the previous thread on this
> topic and is redundant.
Isn't it the opposite? We want SetPageDirty, so PageReserved must _not_
be true.
Paolo
next prev parent reply other threads:[~2018-11-06 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 21:07 [RFC PATCH] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-10-29 22:25 ` Dan Williams
2018-10-30 0:28 ` Barret Rhoden
2018-10-30 3:10 ` Dan Williams
2018-10-30 19:45 ` Barret Rhoden
2018-10-31 8:49 ` Paolo Bonzini
2018-11-02 20:32 ` Barret Rhoden
2018-11-06 10:19 ` Paolo Bonzini [this message]
2018-11-06 16:22 ` Barret Rhoden
2018-10-31 3:05 ` Yu Zhang
2018-10-31 8:52 ` Paolo Bonzini
2018-10-31 21:16 ` Dan Williams
2018-11-06 10:22 ` Paolo Bonzini
2018-11-06 21:05 ` Barret Rhoden
2018-11-06 21:16 ` Paolo Bonzini
2018-11-06 21:17 ` Barret Rhoden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876d5a71-8dda-4728-5329-4e169777ba4a@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=brho@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=yi.z.zhang@intel.com \
--cc=yu.c.zhang@intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).