From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A934C4332F for ; Mon, 28 Nov 2022 16:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232492AbiK1QgD (ORCPT ); Mon, 28 Nov 2022 11:36:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232336AbiK1QgA (ORCPT ); Mon, 28 Nov 2022 11:36:00 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DBE520F6B; Mon, 28 Nov 2022 08:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669653359; x=1701189359; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bpv9EcCzKKYgtgd8XPPXyhjlOvzzWCv3x/6Nbovu2o0=; b=mWN9X+RINOieKi3WCpncPRBOniC7dM/Lq4jrGpdlzpcd/vw5cVjbuMOV OAQnk5zzUzXJlYaohd1H3MzNKP71Eut58Zg41L+MiYPFZ0l/41Igm2acM 2uS4sCwSEp5PeWAYTvHvD/MftvSkPy89uyCj52xUM0KIKc6tSIkOZpgEQ jKRsXY1XmqPMIpHTTOrBlWLCFaTb+/FUJQe9sj/YAB8UQeK72uiAu99Xq Gs/35iukN91dU/mIIGdly/bGQE8ofS6h3yKG1ynDqkTvO3XlCxgDwcll7 edy2yujxvaRTNehy4jigH+vpJuAo3/6MLtfSWJRmPOrgTa8mNY+svTT2n g==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="341794100" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="341794100" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 08:35:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="674280975" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="674280975" Received: from ubik.fi.intel.com (HELO localhost) ([10.237.72.184]) by orsmga008.jf.intel.com with ESMTP; 28 Nov 2022 08:35:53 -0800 From: Alexander Shishkin To: Rob Herring , Will Deacon , Peter Zijlstra , Arnaldo Carvalho de Melo , Ingo Molnar Cc: Namhyung Kim , Jiri Olsa , Mark Rutland , Catalin Marinas , Marc Zyngier , Oliver Upton , Suzuki K Poulose , James Morse , Alexandru Elisei , kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark , Mark Brown , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, alexander.shishkin@linux.intel.com Subject: Re: [PATCH v3 7/8] perf: Add perf_event_attr::config3 In-Reply-To: References: <20220825-arm-spe-v8-7-v3-0-87682f78caac@kernel.org> <20220825-arm-spe-v8-7-v3-7-87682f78caac@kernel.org> <20221118164943.GA4872@willie-the-truck> Date: Mon, 28 Nov 2022 18:35:52 +0200 Message-ID: <877czfujdj.fsf@ubik.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring writes: > On Fri, Nov 18, 2022 at 10:49 AM Will Deacon wrote: >> >> On Fri, Nov 04, 2022 at 10:55:07AM -0500, Rob Herring wrote: >> > @@ -515,6 +516,8 @@ struct perf_event_attr { >> > * truncated accordingly on 32 bit architectures. >> > */ >> > __u64 sig_data; >> > + >> > + __u64 config3; /* extension of config2 */ >> >> I need an ack from the perf core maintainers before I can take this. > > Peter, Arnaldo, Ingo, > > Can I get an ack on this please. It appears that PMUs that don't use config{1,2} and now config3 allow them to be whatever without any validation, whereas in reality we should probably -EINVAL in those cases. Should something be done about that? Regards, -- Alex