Re: [PATCH 02/16] mm/migration: remove unneeded out label

From: "Huang, Ying" <ying.huang@intel.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: <akpm@linux-foundation.org>, <mike.kravetz@oracle.com>,
	<shy828301@gmail.com>, <willy@infradead.org>, <ziy@nvidia.com>,
	<minchan@kernel.org>, <apopple@nvidia.com>,
	<ave.hansen@linux.intel.com>, <o451686892@gmail.com>,
	<almasrymina@google.com>, <jhubbard@nvidia.com>,
	<rcampbell@nvidia.com>, <peterx@redhat.com>,
	<naoya.horiguchi@nec.com>, <mhocko@suse.com>, <riel@redhat.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/16] mm/migration: remove unneeded out label
Date: Mon, 07 Mar 2022 10:03:09 +0800	[thread overview]
Message-ID: <877d967c4i.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20220304093409.25829-3-linmiaohe@huawei.com> (Miaohe Lin's message of "Fri, 4 Mar 2022 17:33:55 +0800")

Miaohe Lin <linmiaohe@huawei.com> writes:

> We can do prep_transhuge_page when newpage is not NULL. Thus we can remove
> out label to simplify the code.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/migrate.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 50bc62d85eaf..bc1867a5706c 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2025,12 +2025,9 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page,
>  
>  	newpage = alloc_pages_node(nid, (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE),
>  				   HPAGE_PMD_ORDER);
> -	if (!newpage)
> -		goto out;
> +	if (newpage)
> +		prep_transhuge_page(newpage);
>  
> -	prep_transhuge_page(newpage);
> -
> -out:
>  	return newpage;
>  }

I don't think this change is necessary.  The original code is simple and
follows the common practice for error processing.  The new code is OK,
but it's unnecessary to change.

Best Regards,
Huang, Ying