From: Thomas Gleixner <tglx@linutronix.de>
To: John Garry <john.garry@huawei.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
Nitesh Lal <nilal@redhat.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, Frank Li <Frank.li@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Shaokun Zhang <zhangshaokun@hisilicon.com>
Subject: Re: [patch 5/8] perf/arm-dsu: Use irq_set_affinity()
Date: Tue, 18 May 2021 17:50:40 +0200 [thread overview]
Message-ID: <877djwdorz.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <4fe8eb68-c940-dd4b-6781-6cdaf052f4f5@huawei.com>
On Tue, May 18 2021 at 12:31, John Garry wrote:
> On 18/05/2021 10:17, Thomas Gleixner wrote:
>>
>> @@ -769,7 +769,6 @@ static int dsu_pmu_device_probe(struct p
>> if (rc) {
>
> nit: I think that someone will send a patch to remove these {} later...
>
>> cpuhp_state_remove_instance(dsu_pmu_cpuhp_state,
>> &dsu_pmu->cpuhp_node);
>> - irq_set_affinity_hint(dsu_pmu->irq, NULL);
>> }
which should be rejected because
cpuhp_state_remove_instance(dsu_pmu_cpuhp_state,
&dsu_pmu->cpuhp_node);
is _NOT_ a one line statement.
if (foo)
cpuhp_state_remove_instance(state, &node);
is fine, but
if (foo)
cpuhp_state_remove_instance(dsu_pmu_cpuhp_state,
&dsu_pmu->cpuhp_node);
breaks the expectation of a single line following the condition which
confuses my brain based OCR. :)
So I left the brackets there on purpose.
Thanks,
tglx
next prev parent reply other threads:[~2021-05-18 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 9:17 [patch 0/8] genirq, perf: Cleanup the abuse of irq_set_affinity_hint() Thomas Gleixner
2021-05-18 9:17 ` [patch 1/8] genirq: Export affinity setter for modules Thomas Gleixner
2021-05-19 9:14 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2021-05-18 9:17 ` [patch 2/8] perf/arm-ccn: Use irq_set_affinity() Thomas Gleixner
2021-05-18 9:17 ` [patch 3/8] perf/arm-cmn: " Thomas Gleixner
2021-05-18 9:17 ` [patch 4/8] perf/arm-dmc620: " Thomas Gleixner
2021-05-18 9:17 ` [patch 5/8] perf/arm-dsu: " Thomas Gleixner
2021-05-18 11:31 ` John Garry
2021-05-18 15:50 ` Thomas Gleixner [this message]
2021-05-18 9:17 ` [patch 6/8] perf/arm-smmuv3: " Thomas Gleixner
2021-05-18 9:17 ` [patch 7/8] perf/imx_ddr: " Thomas Gleixner
2021-05-18 9:17 ` [patch 8/8] perf/hisi: " Thomas Gleixner
2021-05-18 10:11 ` [patch 0/8] genirq, perf: Cleanup the abuse of irq_set_affinity_hint() Mark Rutland
2021-05-18 10:48 ` Will Deacon
2021-05-18 15:51 ` Thomas Gleixner
2021-05-19 9:08 ` Thomas Gleixner
2021-05-24 20:20 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877djwdorz.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Frank.li@nxp.com \
--cc=festevam@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.garry@huawei.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nilal@redhat.com \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).