linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Hillf Danton <hdanton@sina.com>
Cc: Hillf Danton <hdanton@sina.com>, Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org, tj@kernel.org,
	akpm@linux-foundation.org, Peter Zijlstra <peterz@infradead.org>,
	Zqiang <qiang.zhang@windriver.com>
Subject: Re: [RFC PATCH] kthread: do not modify running work
Date: Fri, 02 Oct 2020 10:32:32 +0200	[thread overview]
Message-ID: <877ds9do4f.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201002023412.2276-1-hdanton@sina.com>

On Fri, Oct 02 2020 at 10:34, Hillf Danton wrote:
> On Thu, 01 Oct 2020 15:59:38 +0200 Thomas Gleixner wrote:
>> On Thu, Oct 01 2020 at 17:51, Hillf Danton wrote:
>> Aside of that it's pretty irrelevant whether there is a user at the
>> moment which reschedules work from the callback or not.
>> 
>> It's something which needs to work because its possible from regular
>> work queues as well and makes a lot of sense.
>
> https://lore.kernel.org/lkml/87eemheay8.fsf@nanos.tec.linutronix.de/

That's a completely different thing, really. This adds new functionality
without users and exports it.

kthread work is modeled after workqueue to address specific
needs. delayed work can be rescheduled from the callback and all
variants of timers support rearming the timer from the callback as well.

So having a consistent behaviour accross all these facilities makes
absolutely sense and I don't agree with your sentiment in the changelog
at all.

Just because it does not make sense to you is not a justification for
making stuff inconsistent. You still have not provided a technical
reason why this change is needed.

Thanks,

        tglx


  parent reply	other threads:[~2020-10-02  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200926040426.11936-1-hdanton@sina.com>
2020-09-30 15:01 ` [RFC PATCH] kthread: do not modify running work Petr Mladek
     [not found] ` <20201001095151.5640-1-hdanton@sina.com>
2020-10-01 13:59   ` Thomas Gleixner
     [not found]   ` <20201002023412.2276-1-hdanton@sina.com>
2020-10-02  8:32     ` Thomas Gleixner [this message]
     [not found]     ` <20201004021213.14572-1-hdanton@sina.com>
2020-10-05  8:38       ` Petr Mladek
2020-10-05 11:16         ` Petr Mladek
     [not found]       ` <20201005102105.18272-1-hdanton@sina.com>
2020-10-05 12:20         ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ds9do4f.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=qiang.zhang@windriver.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).