linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>, "Christopherson\,
	Sean J" <sean.j.christopherson@intel.com>,
	Jethro Beekman <jethro@fortanix.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Linux API <linux-api@vger.kernel.org>,
	Jann Horn <jannh@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	X86 ML <x86@kernel.org>, linux-arch <linux-arch@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Rich Felker <dalias@libc.org>,
	nhorman@redhat.com, npmccallum@redhat.com, "Ayoun\,
	Serge" <serge.ayoun@intel.com>,
	shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	carlos@redhat.com
Subject: Re: RFC: userspace exception fixups
Date: Thu, 01 Nov 2018 19:09:17 +0100	[thread overview]
Message-ID: <877ehwisaa.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CALCETrWdpoDkbZjkucKL91GWpDPG9p=VqYrULade2pFDR7S=GQ@mail.gmail.com> (Andy Lutomirski's message of "Thu, 1 Nov 2018 10:53:40 -0700")

* Andy Lutomirski:

> The basic idea would be to allow libc, or maybe even any library, to
> register a handler that gets a chance to act on an exception caused by
> a user instruction before a signal is delivered.  As a straw-man
> example for how this could work, there could be a new syscall:
>
> long register_exception_handler(void (*handler)(int, siginfo_t *, void *));
>
> If a handler is registered, then, if a synchronous exception happens
> (page fault, etc), the kernel would set up an exception frame as usual
> but, rather than checking for signal handlers, it would just call the
> registered handler.  That handler is expected to either handle the
> exception entirely on its own or to call one of two new syscalls to
> ask for normal signal delivery or to ask to retry the faulting
> instruction.

Would the exception handler be a per-thread resource?

If it is: Would the setup and teardown overhead be prohibitive for many
use cases (at least those do not expect a fault)?

Something peripherally related to this interface: Wrappers for signal
handlers (and not just CPU exceptions).  Ideally, we want to maintain a
flag that indicates whether we are in a signal handler, and save and
restore errno around the installed handler.

> Alternatively, we could do something a lot more like the kernel's
> internal fixups where there's a table in user memory that maps
> potentially faulting instructions to landing pads that handle
> exceptions.

GCC already supports that on most Linux targets.  You can unwind from
synchronously invoked signal handlers if you compile with
-fnon-call-exceptions.

However, it's tough to set up a temporary signal handler to trigger such
unwinding because those aren't per-thread.

> On Windows, you can use SEH to do crazy things like running
> known-buggy code and eating the page faults.  I don't think we want to
> go there.

The original SEH was also a rich target for exploiting vulnerabilities.
That's something we really should avoid as well.

I wonder if it would be possible to tack this function onto rseq.

Thanks,
Florian

  reply	other threads:[~2018-11-01 18:09 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 17:53 RFC: userspace exception fixups Andy Lutomirski
2018-11-01 18:09 ` Florian Weimer [this message]
2018-11-01 18:30   ` Rich Felker
2018-11-01 19:00   ` Jarkko Sakkinen
2018-11-01 18:27 ` Rich Felker
2018-11-01 18:33 ` Jann Horn
2018-11-01 18:52   ` Rich Felker
2018-11-01 19:10     ` Linus Torvalds
2018-11-01 19:31       ` Rich Felker
2018-11-01 21:24         ` Linus Torvalds
2018-11-01 23:22           ` Andy Lutomirski
2018-11-02 16:30             ` Sean Christopherson
2018-11-02 16:37               ` Jethro Beekman
2018-11-02 16:52                 ` Sean Christopherson
2018-11-02 16:56                   ` Jethro Beekman
2018-11-02 17:01                     ` Andy Lutomirski
2018-11-02 17:05                       ` Jethro Beekman
2018-11-02 17:16                         ` Andy Lutomirski
2018-11-02 17:32                           ` Rich Felker
2018-11-02 17:12                     ` Sean Christopherson
2018-11-02 22:42                   ` Jarkko Sakkinen
2018-11-02 16:56               ` Dave Hansen
2018-11-02 17:06                 ` Sean Christopherson
2018-11-02 17:13                   ` Dave Hansen
2018-11-02 17:33                     ` Sean Christopherson
2018-11-02 17:48                       ` Andy Lutomirski
2018-11-02 18:27                         ` Sean Christopherson
2018-11-02 19:02                           ` Jann Horn
2018-11-02 22:04                             ` Sean Christopherson
2018-11-02 23:27                               ` Jann Horn
2018-11-02 23:32                                 ` Andy Lutomirski
2018-11-02 23:36                                   ` Jann Horn
2018-11-06 15:37                                   ` Sean Christopherson
2018-11-06 16:57                                     ` Andy Lutomirski
2018-11-06 17:03                                       ` Dave Hansen
2018-11-06 17:19                                       ` Sean Christopherson
2018-11-06 18:20                                         ` Andy Lutomirski
2018-11-06 18:41                                           ` Dave Hansen
2018-11-06 19:02                                             ` Andy Lutomirski
2018-11-06 19:22                                               ` Dave Hansen
2018-11-06 20:12                                                 ` Andy Lutomirski
2018-11-06 21:00                                                   ` Dave Hansen
2018-11-06 21:07                                                     ` Andy Lutomirski
2018-11-06 21:41                                                       ` Andy Lutomirski
2018-11-06 21:59                                                         ` Sean Christopherson
2018-11-06 23:00                                                           ` Andy Lutomirski
2018-11-06 23:35                                                             ` Sean Christopherson
2018-11-06 23:39                                                               ` Andy Lutomirski
2018-11-07  0:02                                                                 ` Sean Christopherson
2018-11-07  1:17                                                                   ` Andy Lutomirski
2018-11-07  6:47                                                                     ` Jethro Beekman
2018-11-07 15:34                                                                     ` Sean Christopherson
2018-11-07 19:01                                                                       ` Sean Christopherson
2018-11-07 20:56                                                                         ` Dave Hansen
2018-11-08 15:04                                                                           ` Jarkko Sakkinen
2018-11-08 19:54                                                       ` Sean Christopherson
2018-11-08 20:05                                                         ` Andy Lutomirski
2018-11-08 20:10                                                           ` Dave Hansen
2018-11-08 21:16                                                             ` Sean Christopherson
2018-11-08 21:50                                                               ` Dave Hansen
2018-11-08 22:04                                                                 ` Sean Christopherson
2018-11-09  7:12                                                           ` Christoph Hellwig
2018-11-06 23:17                                               ` Rich Felker
2018-11-06 23:26                                                 ` Sean Christopherson
2018-11-07 21:27                                                   ` Rich Felker
2018-11-07 21:33                                                     ` Andy Lutomirski
2018-11-07 21:40                                                     ` Sean Christopherson
2018-11-08 15:11                                                       ` Jarkko Sakkinen
2018-11-06 17:00                                     ` Dave Hansen
2018-11-02 22:37             ` Jarkko Sakkinen
2018-11-01 19:06 ` Linus Torvalds
2018-11-02 22:07 ` Jarkko Sakkinen
2018-11-18  7:15 ` Jarkko Sakkinen
2018-11-18  7:18   ` Jarkko Sakkinen
2018-11-18 13:02   ` Jarkko Sakkinen
2018-11-19  5:17     ` Jethro Beekman
2018-11-19 14:05       ` Jarkko Sakkinen
2018-11-19 14:59         ` Jarkko Sakkinen
2018-11-19 15:29   ` Andy Lutomirski
2018-11-19 16:02     ` Jarkko Sakkinen
2018-11-19 17:00       ` Andy Lutomirski
2018-11-20 10:11         ` Jarkko Sakkinen
2018-11-20 15:19           ` Andy Lutomirski
2018-11-20 22:55             ` Jarkko Sakkinen
2018-11-21  5:17               ` Jethro Beekman
2018-11-21 15:17                 ` Jarkko Sakkinen
2018-11-24 17:07                   ` Jarkko Sakkinen
2018-11-26 14:35                   ` Sean Christopherson
2018-11-26 22:06                     ` Jarkko Sakkinen
2018-11-20 18:09           ` Sean Christopherson
2018-11-20 22:46           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ehwisaa.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=carlos@redhat.com \
    --cc=dalias@libc.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=jannh@google.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jethro@fortanix.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nhorman@redhat.com \
    --cc=npmccallum@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sean.j.christopherson@intel.com \
    --cc=serge.ayoun@intel.com \
    --cc=shay.katz-zamir@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).