From: "Huang\, Ying" <ying.huang@intel.com>
To: "Huang\, Ying" <ying.huang@intel.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Nadia Yvette Chambers <nyc@holomorphy.com>,
Michal Hocko <mhocko@suse.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <willy@linux.intel.com>,
Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
Shaohua Li <shli@fb.com>
Subject: Re: [PATCH -mm] mm: Clear to access sub-page last when clearing huge page
Date: Tue, 08 Aug 2017 15:40:04 +0800 [thread overview]
Message-ID: <877eye7bjf.fsf@yhuang-mobile.sh.intel.com> (raw)
In-Reply-To: <87efsngff5.fsf@yhuang-mobile.sh.intel.com> (Ying Huang's message of "Tue, 8 Aug 2017 06:51:26 +0800")
"Huang, Ying" <ying.huang@intel.com> writes:
> "Kirill A. Shutemov" <kirill@shutemov.name> writes:
>
>> On Mon, Aug 07, 2017 at 03:21:31PM +0800, Huang, Ying wrote:
>>> From: Huang Ying <ying.huang@intel.com>
>>>
>>> Huge page helps to reduce TLB miss rate, but it has higher cache
>>> footprint, sometimes this may cause some issue. For example, when
>>> clearing huge page on x86_64 platform, the cache footprint is 2M. But
>>> on a Xeon E5 v3 2699 CPU, there are 18 cores, 36 threads, and only 45M
>>> LLC (last level cache). That is, in average, there are 2.5M LLC for
>>> each core and 1.25M LLC for each thread. If the cache pressure is
>>> heavy when clearing the huge page, and we clear the huge page from the
>>> begin to the end, it is possible that the begin of huge page is
>>> evicted from the cache after we finishing clearing the end of the huge
>>> page. And it is possible for the application to access the begin of
>>> the huge page after clearing the huge page.
>>>
>>> To help the above situation, in this patch, when we clear a huge page,
>>> the order to clear sub-pages is changed. In quite some situation, we
>>> can get the address that the application will access after we clear
>>> the huge page, for example, in a page fault handler. Instead of
>>> clearing the huge page from begin to end, we will clear the sub-pages
>>> farthest from the the sub-page to access firstly, and clear the
>>> sub-page to access last. This will make the sub-page to access most
>>> cache-hot and sub-pages around it more cache-hot too. If we cannot
>>> know the address the application will access, the begin of the huge
>>> page is assumed to be the the address the application will access.
>>>
>>> With this patch, the throughput increases ~28.3% in vm-scalability
>>> anon-w-seq test case with 72 processes on a 2 socket Xeon E5 v3 2699
>>> system (36 cores, 72 threads). The test case creates 72 processes,
>>> each process mmap a big anonymous memory area and writes to it from
>>> the begin to the end. For each process, other processes could be seen
>>> as other workload which generates heavy cache pressure. At the same
>>> time, the cache miss rate reduced from ~33.4% to ~31.7%, the
>>> IPC (instruction per cycle) increased from 0.56 to 0.74, and the time
>>> spent in user space is reduced ~7.9%
>>
>> That's impressive.
>>
>> But what about the case when we are not bounded that much by the size of
>> LLC? What about running the same test on the same hardware, but with 4
>> processes instead of 72.
>>
>> I just want to make sure we don't regress on more realistic tast case.
>
> Sure. I will test it.
Tested with 4 processes, there is no visible changes for benchmark result.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2017-08-08 7:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 7:21 [PATCH -mm] mm: Clear to access sub-page last when clearing huge page Huang, Ying
2017-08-07 9:55 ` Jan Kara
2017-08-07 10:00 ` Huang, Ying
2017-08-07 10:16 ` Kirill A. Shutemov
2017-08-07 22:51 ` Huang, Ying
2017-08-08 7:40 ` Huang, Ying [this message]
2017-08-07 18:46 ` Christopher Lameter
2017-08-07 23:05 ` Huang, Ying
2017-08-08 6:26 ` Huang, Ying
2017-08-08 4:07 ` Mike Kravetz
2017-08-08 4:24 ` Huang, Ying
2017-08-08 12:12 ` Matthew Wilcox
2017-08-08 23:06 ` Huang, Ying
2017-08-09 21:25 ` Andrew Morton
2017-08-10 0:58 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eye7bjf.fsf@yhuang-mobile.sh.intel.com \
--to=ying.huang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=nyc@holomorphy.com \
--cc=shli@fb.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).