From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751130AbdHBEYZ (ORCPT ); Wed, 2 Aug 2017 00:24:25 -0400 Received: from ozlabs.org ([103.22.144.67]:51399 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbdHBEYX (ORCPT ); Wed, 2 Aug 2017 00:24:23 -0400 From: Michael Ellerman To: Minchan Kim , Mike Galbraith , Andrew Morton Cc: Jerome Marchand , LKML , Nitin Gupta Subject: Re: [zram] ltp inspired explosion - master v4.13-rc1-3-g87b2c3fc6317 In-Reply-To: <20170725062650.GA12134@bbox> References: <1500283045.7885.37.camel@gmx.de> <1500920221.16574.7.camel@gmx.de> <20170725062650.GA12134@bbox> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 02 Aug 2017 14:24:20 +1000 Message-ID: <877eymsikr.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minchan Kim writes: > From 0ffbd3c8769fdf56e2f14908f890f9d1703ed32e Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 25 Jul 2017 15:15:18 +0900 > Subject: [PATCH] zram: do not free pool->size_class > > Mike reported kernel goes oops with ltp:zram03 testcase. ... > > He bisected the problem is [1]. > > By [1], zram doesn't use double pointer for pool->size_class any more > in zs_create_pool so counter function zs_destroy_pool don't need to > free it, either. Otherwise, it does kfree wrong address and then, > kernel goes Oops. > > [1] cf8e0fedf078 mm/zsmalloc: simplify zs_max_alloc_size handling > > Cc: Jerome Marchand > Reported-by: Mike Galbraith > Signed-off-by: Minchan Kim > --- > mm/zsmalloc.c | 1 - > 1 file changed, 1 deletion(-) I just bisected this too. How about a fixes tag to help the next chump who hits it? Fixes: cf8e0fedf078 ("mm/zsmalloc: simplify zs_max_alloc_size handling") cheers