From: Jani Nikula <jani.nikula@linux.intel.com>
To: Peter Senna Tschudin <peter.senna@collabora.com>,
Archit Taneja <architt@codeaurora.org>
Cc: mark.rutland@arm.com, daniel.vetter@ffwll.ch,
peter.senna@gmail.com, dri-devel@lists.freedesktop.org,
tiwai@suse.com, ykk@rock-chips.com, jslaby@suse.cz,
martyn.welch@collabora.co.uk, mchehab@osg.samsung.com,
linux@armlinux.org.uk, javier@dowhile0.org, treding@nvidia.com,
linux@roeck-us.net, martin.donnelly@ge.com,
devicetree@vger.kernel.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk,
Fabio Estevam <fabio.estevam@nxp.com>,
rmk+kernel@armlinux.org.uk, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
galak@codeaurora.org, enric.balletbo@collabora.com,
akpm@linux-foundation.org, shawnguo@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge
Date: Mon, 30 Jan 2017 19:05:31 +0200 [thread overview]
Message-ID: <877f5ciilg.fsf@intel.com> (raw)
In-Reply-To: <20170128141646.GA21291@collabora.com>
On Sat, 28 Jan 2017, Peter Senna Tschudin <peter.senna@collabora.com> wrote:
> On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
> Hi Archit,
>
> Thank you for the comments!
>
> [...]
>> > + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
>> > + if (total_size > EDID_LENGTH) {
>> > + kfree(block);
>> > + block = kmalloc(total_size, GFP_KERNEL);
>> > + if (!block)
>> > + return NULL;
>> > +
>> > + /* Yes, read the entire buffer, and do not skip the first
>> > + * EDID_LENGTH bytes.
>> > + */
>>
>> Is this the reason why you aren't using drm_do_get_edid()?
>
> Yes, for some hw specific reason, it is necessary to read the entire
> EDID buffer starting from 0, not block by block.
Hrmh, I'm planning on moving the edid override and firmware edid
mechanisms at the drm_do_get_edid() level to be able to truly and
transparently use a different edid. Currently, they're only used for
modes, really, and lead to some info retrieved from overrides, some from
the real edid. This kind of hacks will bypass the override/firmware edid
mechanisms then too. :(
BR,
Jani.
>
> [...]
>
> I fixed all your other suggestions. Thank you!
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-01-30 17:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 20:24 [PATCH V7 0/4] Add driver for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin
2017-01-01 20:24 ` [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp Peter Senna Tschudin
2017-01-03 22:51 ` Rob Herring
2017-01-03 23:34 ` Peter Senna Tschudin
2017-01-04 20:39 ` Rob Herring
2017-01-07 1:29 ` Peter Senna Tschudin
2017-01-10 21:04 ` Laurent Pinchart
2017-01-16 8:37 ` Peter Senna Tschudin
2017-01-18 21:10 ` Laurent Pinchart
2017-01-19 8:12 ` Peter Senna Tschudin
2017-01-19 8:17 ` Laurent Pinchart
2017-01-19 9:25 ` Peter Senna Tschudin
2017-01-19 11:49 ` Laurent Pinchart
2017-01-10 21:06 ` Laurent Pinchart
2017-01-01 20:24 ` [PATCH V7 2/4] MAINTAINERS: Add entry for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin
2017-01-01 20:24 ` [PATCH V7 3/4] drm/bridge: Add driver " Peter Senna Tschudin
2017-01-02 11:26 ` Peter Senna Tschudin
2017-01-05 7:48 ` Archit Taneja
2017-01-28 14:16 ` Peter Senna Tschudin
2017-01-30 17:05 ` Jani Nikula [this message]
2017-02-01 9:44 ` Archit Taneja
2017-02-01 10:58 ` Peter Senna Tschudin
2017-02-01 11:35 ` Daniel Vetter
2017-02-01 12:21 ` Peter Senna Tschudin
2017-02-02 9:56 ` Archit Taneja
2017-02-02 1:46 ` Emil Velikov
2017-02-02 11:53 ` Peter Senna Tschudin
2017-02-02 12:37 ` Emil Velikov
2017-02-03 8:00 ` Daniel Vetter
2017-02-03 12:25 ` Emil Velikov
2017-02-06 8:45 ` Daniel Vetter
2017-01-01 20:24 ` [PATCH V7 4/4] dts/imx6q-b850v3: Use " Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f5ciilg.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=fabio.estevam@nxp.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@dowhile0.org \
--cc=jslaby@suse.cz \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=martin.donnelly@ge.com \
--cc=martyn.welch@collabora.co.uk \
--cc=mchehab@osg.samsung.com \
--cc=pawel.moll@arm.com \
--cc=peter.senna@collabora.com \
--cc=peter.senna@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tiwai@suse.com \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).