Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage

From: Felipe Balbi <balbi@ti.com>
To: Andy Gross <agross@codeaurora.org>, <linux-arm-msm@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-usb@vger.kernel.org>, Greg KH <gregkh@linuxfoundation.org>,
	<devicetree@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Andy Gross <agross@codeaurora.org>
Subject: Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage
Date: Fri, 20 Nov 2015 09:08:46 -0600	[thread overview]
Message-ID: <877flcemip.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <1448008509-8913-5-git-send-email-agross@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Hi,

Andy Gross <agross@codeaurora.org> writes:
> This patch adds documentation for the optional syscon-tcsr property in the
> Qualcomm DWC3 node.  The syscon-tcsr specifies the register and bit used to
> configure the TCSR USB phy mux register.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> index ca164e7..dfa222d 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> @@ -8,6 +8,10 @@ Required properties:
>    "core"		Master/Core clock, have to be >= 125 MHz for SS
>  				operation and >= 60MHz for HS operation
>  
> +Optional properties:
> +- syscon-tcsr	Specifies TCSR handle, register offset, and bit position for
> +			configuring the phy mux setting.

oh, it's a PHY mux ? I don't think it should be part of any dwc3-* glue
layer then. By the time we reach dwc3, the mux should be properly
configured.

Kishon, any ideas ?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]