linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: mingo@kernel.org, peterz@infradead.org, jamie.iles@oracle.com,
	penberg@kernel.org, acme@ghostprotocols.net, paulus@samba.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11] liblockdep: preload helper
Date: Thu, 07 Feb 2013 15:19:36 +0900	[thread overview]
Message-ID: <877gmksl1j.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1360188694-25077-12-git-send-email-sasha.levin@oracle.com> (Sasha Levin's message of "Wed, 6 Feb 2013 17:11:34 -0500")

Hi Sasha,

On Wed,  6 Feb 2013 17:11:34 -0500, Sasha Levin wrote:
> This is a simple wrapper to make using liblockdep on existing applications
> much easier.
>
> After running 'make && make install', it becomes quite simple to test things
> with liblockdep. For example, to try it on perf:
>
> 	liblockdep perf

Shouldn't it be 'lockdep perf ...'?

Thanks,
Namhyung

>
> No other integration required.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>  tools/lib/lockdep/Makefile | 12 ++++++++----
>  tools/lib/lockdep/lockdep  |  3 +++
>  2 files changed, 11 insertions(+), 4 deletions(-)
>  create mode 100755 tools/lib/lockdep/lockdep
>
> diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
> index 245f8ba..b22122f 100644
> --- a/tools/lib/lockdep/Makefile
> +++ b/tools/lib/lockdep/Makefile
> @@ -34,7 +34,9 @@ DESTDIR ?=
>  DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
>  
>  prefix ?= /usr/local
> -bindir_relative = lib
> +libdir_relative = lib
> +libdir = $(prefix)/$(libdir_relative)
> +bindir_relative = bin
>  bindir = $(prefix)/$(bindir_relative)
>  
>  export DESTDIR DESTDIR_SQ INSTALL
> @@ -90,13 +92,14 @@ objtree		:= $(CURDIR)
>  src		:= $(srctree)
>  obj		:= $(objtree)
>  
> -export prefix bindir src obj
> +export prefix libdir bindir src obj
>  
>  # Shell quotes
> +libdir_SQ = $(subst ','\'',$(libdir))
>  bindir_SQ = $(subst ','\'',$(bindir))
> -bindir_relative_SQ = $(subst ','\'',$(bindir_relative))
>  
>  LIB_FILE = liblockdep.a liblockdep.so
> +BIN_FILE = lockdep
>  
>  CONFIG_INCLUDES =
>  CONFIG_LIBS	=
> @@ -229,7 +232,8 @@ define do_install
>  endef
>  
>  install_lib: all_cmd
> -	$(Q)$(call do_install,$(LIB_FILE),$(bindir_SQ))
> +	$(Q)$(call do_install,$(LIB_FILE),$(libdir_SQ))
> +	$(Q)$(call do_install,$(BIN_FILE),$(bindir_SQ))
>  
>  install: install_lib
>  
> diff --git a/tools/lib/lockdep/lockdep b/tools/lib/lockdep/lockdep
> new file mode 100755
> index 0000000..616bf9a
> --- /dev/null
> +++ b/tools/lib/lockdep/lockdep
> @@ -0,0 +1,3 @@
> +#! /bin/bash
> +
> +LD_PRELOAD=liblockdep.so "$@"

  reply	other threads:[~2013-02-07  6:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 22:11 [PATCH 00/11] lockdep: LD_PRELOAD support Sasha Levin
2013-02-06 22:11 ` [PATCH 01/11] liblockdep: remove the need for liblockdep_init Sasha Levin
2013-02-06 22:11 ` [PATCH 02/11] liblockdep: remove the need for liblockdep_set_thread Sasha Levin
2013-02-06 22:11 ` [PATCH 03/11] perf: stop using liblockdep_init and liblockdep_set_thread Sasha Levin
2013-02-06 22:11 ` [PATCH 04/11] liblockdep: fix AA test Sasha Levin
2013-02-06 22:11 ` [PATCH 05/11] liblockdep: correct the ABCDBCDA test Sasha Levin
2013-02-06 22:11 ` [PATCH 06/11] liblockdep: rbtree support Sasha Levin
2013-02-06 22:11 ` [PATCH 07/11] liblockdep: prevent multiple declarations of CALLER_ADDR0 Sasha Levin
2013-02-06 22:11 ` [PATCH 08/11] liblockdep: keep headers declarations even if lib is disabled Sasha Levin
2013-02-06 22:11 ` [PATCH 09/11] liblockdep: support using LD_PRELOAD Sasha Levin
2013-02-07 10:28   ` Jamie Iles
2013-02-07 14:31     ` Sasha Levin
2013-02-08 10:43       ` Jamie Iles
2013-02-08 23:55         ` Sasha Levin
2013-02-06 22:11 ` [PATCH 10/11] liblockdep: add tests for the LD_PRELOAD feature Sasha Levin
2013-02-06 22:11 ` [PATCH 11/11] liblockdep: preload helper Sasha Levin
2013-02-07  6:19   ` Namhyung Kim [this message]
2013-02-07  6:55   ` Namhyung Kim
2013-02-07 14:29     ` Sasha Levin
2013-02-07  7:07 ` [PATCH 00/11] lockdep: LD_PRELOAD support Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gmksl1j.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=jamie.iles@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).