linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tianxianting <tian.xianting@h3c.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] tracing: use __this_cpu_read() in trace_buffered_event_enable()
Date: Fri, 18 Sep 2020 01:21:37 +0000	[thread overview]
Message-ID: <87803c1d960c4b17b59eb39346fdb028@h3c.com> (raw)
In-Reply-To: <20200917203127.091e23f2@rorschach.local.home>

Hi Steven,
Thanks for your reply:)

-----Original Message-----
From: Steven Rostedt [mailto:rostedt@goodmis.org] 
Sent: Friday, September 18, 2020 8:31 AM
To: tianxianting (RD) <tian.xianting@h3c.com>
Cc: mingo@redhat.com; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: use __this_cpu_read() in trace_buffered_event_enable()

Sorry for the late reply (been busy with Linux Plumbers, took a vacation, and then trying to catch up on all my email for the last two
months!)

But I just wanted to let you know that I added this to my queue.

Thanks!

-- Steve


On Thu, 13 Aug 2020 19:28:03 +0800
Xianting Tian <tian.xianting@h3c.com> wrote:

> The code is executed with preemption disabled, so it's safe to use 
> __this_cpu_read().
> 
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> ---
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 
> bb6226972..7d0d71ce9 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2514,7 +2514,7 @@ void trace_buffered_event_enable(void)
>  
>  		preempt_disable();
>  		if (cpu == smp_processor_id() &&
> -		    this_cpu_read(trace_buffered_event) !=
> +		    __this_cpu_read(trace_buffered_event) !=
>  		    per_cpu(trace_buffered_event, cpu))
>  			WARN_ON_ONCE(1);
>  		preempt_enable();


      reply	other threads:[~2020-09-18  1:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 11:28 [PATCH] tracing: use __this_cpu_read() in trace_buffered_event_enable() Xianting Tian
2020-09-18  0:31 ` Steven Rostedt
2020-09-18  1:21   ` Tianxianting [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87803c1d960c4b17b59eb39346fdb028@h3c.com \
    --to=tian.xianting@h3c.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).