From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] cpuset: Fix cpuset_cpus_allowed() to not filter offline CPUs
Date: Thu, 2 Feb 2023 16:05:14 -0500 [thread overview]
Message-ID: <8787b5f7-9822-e49b-0357-d0ce224ca920@redhat.com> (raw)
In-Reply-To: <75de91db-d3bc-0c0e-6199-ef00591e8878@redhat.com>
On 2/2/23 15:53, Waiman Long wrote:
>
> On 2/2/23 15:48, Tejun Heo wrote:
>> On Thu, Feb 02, 2023 at 03:46:02PM -0500, Waiman Long wrote:
>>>>> I will work on a patchset to do that as a counter offer.
>>>> We will need a small and simple patch for /urgent, or I will need to
>>>> revert all your patches -- your call.
>>>>
>>>> I also don't tihnk you fully appreciate the ramifications of
>>>> task_cpu_possible_mask(), cpuset currently gets that quite wrong.
>>> OK, I don't realize the urgency of that. If it is that urgent, I
>>> will have
>>> no objection to get it in for now. We can improve it later on. So
>>> are you
>>> planning to get it into the current 6.2 rc or 6.3?
>>>
>>> Tejun, are you OK with that as you are the cgroup maintainer?
>> Yeah, gotta fix the regression but is there currently a solution
>> which fixes
>> the regression but doesn't further break other stuff?
>
> I believe there is a better way to do that, but it will need more time
> to flex out. Since cpuset_cpus_allowed() is only used by
> kernel/sched/core.c, Peter will be responsible if it somehow breaks
> other stuff.
Maybe my cpuset patch that don't update task's cpumask on cpu offline
event can help. However, I don't know the exact scenario where the
regression happen, so it may not.
Cheers,
Longman
next prev parent reply other threads:[~2023-02-02 21:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 22:17 [PATCH 0/2] Fix broken cpuset affinity handling on heterogeneous systems Will Deacon
2023-01-31 22:17 ` [PATCH 1/2] cpuset: Fix cpuset_cpus_allowed() to not filter offline CPUs Will Deacon
2023-02-01 4:14 ` Waiman Long
2023-02-01 9:14 ` Peter Zijlstra
2023-02-01 15:16 ` Waiman Long
2023-02-01 18:46 ` Waiman Long
2023-02-01 19:14 ` Waiman Long
2023-02-01 19:17 ` Waiman Long
2023-02-01 21:10 ` Peter Zijlstra
2023-02-02 3:34 ` Waiman Long
2023-02-03 11:50 ` Will Deacon
2023-02-03 15:13 ` Waiman Long
2023-02-03 15:26 ` Peter Zijlstra
2023-02-03 15:35 ` Waiman Long
2023-02-02 8:34 ` Peter Zijlstra
2023-02-02 16:06 ` Waiman Long
2023-02-02 19:42 ` Peter Zijlstra
2023-02-02 20:46 ` Waiman Long
2023-02-02 20:48 ` Tejun Heo
2023-02-02 20:53 ` Waiman Long
2023-02-02 21:05 ` Waiman Long [this message]
2023-02-02 21:50 ` Tejun Heo
2023-02-03 0:54 ` Waiman Long
2023-02-03 16:31 ` Will Deacon
2023-01-31 22:17 ` [PATCH 2/2] cpuset: Call set_cpus_allowed_ptr() with appropriate mask for task Will Deacon
2023-02-01 2:22 ` Waiman Long
2023-02-01 9:15 ` Peter Zijlstra
2023-02-01 15:03 ` Waiman Long
2023-02-01 9:27 ` Peter Zijlstra
2023-02-03 17:55 ` Waiman Long
2023-02-06 20:21 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8787b5f7-9822-e49b-0357-d0ce224ca920@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).