From: Thomas Gleixner <tglx@linutronix.de>
To: Usama Arif <usama.arif@bytedance.com>,
dwmw2@infradead.org, kim.phillips@amd.com
Cc: arjan@linux.intel.com, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
pbonzini@redhat.com, paulmck@kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com,
thomas.lendacky@amd.com, seanjc@google.com,
pmenzel@molgen.mpg.de, fam.zheng@bytedance.com,
punit.agrawal@bytedance.com, simon.evans@bytedance.com,
liangma@liangbit.com, David Woodhouse <dwmw@amazon.co.uk>
Subject: Re: [External] Re: [PATCH v8 8/9] x86/mtrr: Avoid repeated save of MTRRs on boot-time CPU bringup
Date: Fri, 10 Feb 2023 00:50:30 +0100 [thread overview]
Message-ID: <878rh61jqx.ffs@tglx> (raw)
In-Reply-To: <9b6bca9c-7189-a2d5-8c0a-f55c24f54b62@bytedance.com>
On Thu, Feb 09 2023 at 20:32, Usama Arif wrote:
> On 09/02/2023 18:31, Thomas Gleixner wrote:
>>> first_cpu = cpumask_first(cpu_online_mask);
>>> smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1);
>>
>> So why is this relevant after the initial bringup? The BP MTRRs have
>> been saved already above, no?
>>
>
> I will let David confirm if this is correct and why he did it, but this
> is what I thought while reviewing before posting v4:
>
> - At initial boot (system_state < SYSTEM_RUNNING), when mtrr_save_state
> is called in do_cpu_up at roughly the same time so MTRR is going to be
> the same, we can just save it once and then reuse for other secondary
> cores as it wouldn't have changed for the rest of the do_cpu_up calls.
>
> - When the system is running and you offline and then online a CPU, you
> want to make sure that hotplugged CPU gets the current MTRR (which might
> have changed since boot?), incase the MTRR has changed after the system
> has been booted, you save the MTRR of the first online CPU. When the
> hotplugged CPU runs its initialisation code, its fixed-range MTRRs will
> be updated with the newly saved fixed-range MTRRs.
I knew that already :) But seriously:
If the MTRRs are changed post boot then the cached values want to be
updated too.
We are not making these changes just to satisfy some fast boot
challenge. They have to make sense in general.
And this does not amke sense at all.
Thanks,
tglx
next prev parent reply other threads:[~2023-02-09 23:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 15:41 [PATCH v8 0/9] Parallel CPU bringup for x86_64 Usama Arif
2023-02-09 15:41 ` [PATCH v8 1/9] x86/apic/x2apic: Allow CPU cluster_mask to be populated in parallel Usama Arif
2023-02-09 15:41 ` [PATCH v8 2/9] cpu/hotplug: Move idle_thread_get() to <linux/smpboot.h> Usama Arif
2023-02-09 15:41 ` [PATCH v8 3/9] cpu/hotplug: Add dynamic parallel bringup states before CPUHP_BRINGUP_CPU Usama Arif
2023-02-09 15:41 ` [PATCH v8 4/9] x86/smpboot: Reference count on smpboot_setup_warm_reset_vector() Usama Arif
2023-02-09 15:41 ` [PATCH v8 5/9] x86/smpboot: Split up native_cpu_up into separate phases and document them Usama Arif
2023-02-09 15:41 ` [PATCH v8 6/9] x86/smpboot: Support parallel startup of secondary CPUs Usama Arif
2023-02-09 18:25 ` Thomas Gleixner
2023-02-09 20:37 ` [External] " Usama Arif
2023-02-09 15:41 ` [PATCH v8 7/9] x86/smpboot: Send INIT/SIPI/SIPI to secondary CPUs in parallel Usama Arif
2023-02-09 15:41 ` [PATCH v8 8/9] x86/mtrr: Avoid repeated save of MTRRs on boot-time CPU bringup Usama Arif
2023-02-09 18:31 ` Thomas Gleixner
2023-02-09 20:32 ` [External] " Usama Arif
2023-02-09 20:37 ` David Woodhouse
2023-02-09 23:50 ` Thomas Gleixner [this message]
2023-02-10 8:55 ` David Woodhouse
2023-02-13 15:19 ` Usama Arif
2023-02-13 20:42 ` Thomas Gleixner
2023-02-09 15:41 ` [PATCH v8 9/9] x86/smpboot: Serialize topology updates for secondary bringup Usama Arif
2023-02-13 20:43 ` Thomas Gleixner
2023-02-13 20:53 ` David Woodhouse
2023-02-13 22:30 ` [External] " Usama Arif
2023-02-14 6:57 ` David Woodhouse
2023-02-10 4:11 ` [PATCH v8 0/9] Parallel CPU bringup for x86_64 Paul E. McKenney
2023-02-10 9:02 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rh61jqx.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=fam.zheng@bytedance.com \
--cc=hewenliang4@huawei.com \
--cc=hpa@zytor.com \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=liangma@liangbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mimoja@mimoja.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=punit.agrawal@bytedance.com \
--cc=rcu@vger.kernel.org \
--cc=seanjc@google.com \
--cc=simon.evans@bytedance.com \
--cc=thomas.lendacky@amd.com \
--cc=usama.arif@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).