From: Felipe Balbi <balbi@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/patch 2/2] arm64: boot: dts: qcom: surface duo: add minimal framebuffer
Date: Sat, 18 Dec 2021 09:19:07 +0200 [thread overview]
Message-ID: <878rwi4bwt.fsf@kernel.org> (raw)
In-Reply-To: <e2ed8317-a656-f6ac-9fc5-810588f33105@somainline.org>
Hi,
Konrad Dybcio <konrad.dybcio@somainline.org> writes:
> On 17.12.2021 13:57, Felipe Balbi wrote:
>> From: Felipe Balbi <felipe.balbi@microsoft.com>
>>
>> Add a minimal framebuffer device so we can use the display on the
>> Surface Duo device.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@microsoft.com>
>> ---
>> .../dts/qcom/sm8150-microsoft-surface-duo.dts | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
>> index a73317e1a824..c629ec115fec 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
>> @@ -25,6 +25,17 @@ chosen {
>> stdout-path = "serial0:115200n8";
>> };
>>
>> + framebuffer0: framebuffer@9c000000 {
>> + compatible = "simple-framebuffer";
>> + reg = <0 0x9c000000 0 0x02400000>;
>
> You can remove the leading 0 in the size cell.
okay
>> + status = "okay";
>
> This line is unnecessary, as it's enabled by default
understood
>> @@ -472,6 +483,14 @@ &pon_resin {
>> linux,code = <KEY_VOLUMEDOWN>;
>> };
>>
>> +&reserved_memory {
>> + splash_region: splash_region@9c000000 {
>> + /* We expect the bootloader to fill in the size */
>
> Would it be different than the framebuffer size?
honestly, I used this mainly to get the correct base address and size. I
had 0 everywhere and bootloader filled the entire thing for me. I can
just hardcode with the expected values anyway.
--
balbi
next prev parent reply other threads:[~2021-12-18 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 12:57 [RFC/patch 0/2] arm64: boot: dts: qcom: sm8150: enable framebuffer for Surface Duo Felipe Balbi
2021-12-17 12:57 ` [RFC/patch 1/2] arm64: boot: dts: qcom: sm8150: add a label for reserved-memory Felipe Balbi
2021-12-17 12:57 ` [RFC/patch 2/2] arm64: boot: dts: qcom: surface duo: add minimal framebuffer Felipe Balbi
2021-12-17 17:32 ` Konrad Dybcio
2021-12-18 7:19 ` Felipe Balbi [this message]
[not found] ` <92001103-6b29-7ad9-eea3-34fd30c5f767@postmarketos.org>
2021-12-18 7:15 ` Felipe Balbi
2021-12-17 17:16 ` [RFC/patch 0/2] arm64: boot: dts: qcom: sm8150: enable framebuffer for Surface Duo Konrad Dybcio
2021-12-18 7:17 ` Felipe Balbi
2021-12-18 9:13 ` Konrad Dybcio
2021-12-18 0:24 ` Dmitry Baryshkov
2021-12-18 7:17 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rwi4bwt.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).