From: Marc Zyngier <maz@kernel.org>
To: Zhaoyu Liu <zackary.liu.pro@gmail.com>
Cc: alyssa@rosenzweig.io, lorenzo.pieralisi@arm.com, robh@kernel.org,
kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci/controller/pcie-apple: remove the indentation beside arguments of DECLARE_BITMAP
Date: Mon, 01 Nov 2021 10:31:54 +0000 [thread overview]
Message-ID: <878ry89nfp.wl-maz@kernel.org> (raw)
In-Reply-To: <20211031135544.GA1616@pc>
On Sun, 31 Oct 2021 13:55:48 +0000,
Zhaoyu Liu <zackary.liu.pro@gmail.com> wrote:
>
> When "make tags", it prompts a warning:
>
> ctags: Warning: drivers/pci/controller/pcie-apple.c:150:
> null expansion of name pattern "\1"
>
> Ctags regular can not be matched due to indentation, so remove it.
> Same fix as in commit 5fdf876d30ce ("KVM: arm: Do not indent
> the arguments of DECLARE_BITMAP")
>
> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>
> ---
> drivers/pci/controller/pcie-apple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index b665d29af77a..955134464d84 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -147,7 +147,7 @@ struct apple_pcie_port {
> void __iomem *base;
> struct irq_domain *domain;
> struct list_head entry;
> - DECLARE_BITMAP( sid_map, MAX_RID2SID);
> + DECLARE_BITMAP(sid_map, MAX_RID2SID);
> int sid_map_sz;
> int idx;
> };
This really feels like we're papering over a tooling bug. Other
tagging systems do not seem to suffer from this (I use gtags myself).
It is easily fixed with the following patch, at least with my
setup. Can you please give it a go?
Thanks,
M.
diff --git a/scripts/tags.sh b/scripts/tags.sh
index b24bfaec6290..7e5f19391f20 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -186,7 +186,7 @@ regex_c=(
'/\<DEFINE_\(RT_MUTEX\|MUTEX\|SEMAPHORE\|SPINLOCK\)(\([[:alnum:]_]*\)/\2/v/'
'/\<DEFINE_\(RAW_SPINLOCK\|RWLOCK\|SEQLOCK\)(\([[:alnum:]_]*\)/\2/v/'
'/\<DECLARE_\(RWSEM\|COMPLETION\)(\([[:alnum:]_]\+\)/\2/v/'
- '/\<DECLARE_BITMAP(\([[:alnum:]_]*\)/\1/v/'
+ '/\<DECLARE_BITMAP([[:space:]]*\([[:alnum:]_]*\)/\1/v/'
'/\(^\|\s\)\(\|L\|H\)LIST_HEAD(\([[:alnum:]_]*\)/\3/v/'
'/\(^\|\s\)RADIX_TREE(\([[:alnum:]_]*\)/\2/v/'
'/\<DEFINE_PER_CPU([^,]*, *\([[:alnum:]_]*\)/\1/v/'
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2021-11-01 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 13:55 [PATCH] pci/controller/pcie-apple: remove the indentation beside arguments of DECLARE_BITMAP Zhaoyu Liu
2021-11-01 10:31 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ry89nfp.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=zackary.liu.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).