From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D07C433ED for ; Sat, 15 May 2021 18:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76B366112D for ; Sat, 15 May 2021 18:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234442AbhEOSZ0 (ORCPT ); Sat, 15 May 2021 14:25:26 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:41872 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234318AbhEOSZT (ORCPT ); Sat, 15 May 2021 14:25:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621103045; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=ch3A0RldTQj2BJift1c1BerWB0aD14nIhxK4TmHg/Ss=; b=VyGlR7M25106qM9D4vwFhOalFA08ztlG3d6d6/mjoWU6FsAHnHT5VaPUvSVbPXtC2ZkEO3Ah IXUmJAqKeCRISpGO5mNlZ9lF5s6wK409xcPUM+X/5VcnClFs/yX/OqOhgorABGrmdsAiu0K/ WcGL8GauyWYRJy4H9fIZXZW2cBQ= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60a011bd7b5af81b5c419f5e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 15 May 2021 18:23:57 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C0EF0C4323A; Sat, 15 May 2021 18:23:57 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 86F7AC433D3; Sat, 15 May 2021 18:23:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 86F7AC433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: linux-arch , Linus Torvalds , Vineet Gupta , Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , "David S. Miller" , Jakub Kicinski , Devidas Puranik , linux-wireless , Networking , Linux Kernel Mailing List , devidas.puranik@nxp.com Subject: Re: [PATCH v2 10/13] mwifiex: re-fix for unaligned accesses References: <20210514100106.3404011-1-arnd@kernel.org> <20210514100106.3404011-11-arnd@kernel.org> <87lf8gikhp.fsf@codeaurora.org> Date: Sat, 15 May 2021 21:23:51 +0300 In-Reply-To: (Arnd Bergmann's message of "Sat, 15 May 2021 11:01:02 +0200") Message-ID: <878s4fj1oo.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On Sat, May 15, 2021 at 8:22 AM Kalle Valo wrote: >> Arnd Bergmann writes: >> > From: Arnd Bergmann >> > >> > A patch from 2017 changed some accesses to DMA memory to use >> > get_unaligned_le32() and similar interfaces, to avoid problems >> > with doing unaligned accesson uncached memory. >> > >> > However, the change in the mwifiex_pcie_alloc_sleep_cookie_buf() >> > function ended up changing the size of the access instead, >> > as it operates on a pointer to u8. >> > >> > Change this function back to actually access the entire 32 bits. >> > Note that the pointer is aligned by definition because it came >> > from dma_alloc_coherent(). >> > >> > Fixes: 92c70a958b0b ("mwifiex: fix for unaligned reads") >> > Signed-off-by: Arnd Bergmann >> >> Via which tree should this go? I assume it will go via some other tree >> so: >> >> Acked-by: Kalle Valo > > I have queued the series in the asm-generic tree for 5.14, as the patches > that depend on this one are a little too invasive for 5.13 at this point. > > If you think this fix should be in 5.13, please take it through your tree. I think v5.14 is more approriate, so please take this via your tree. Thanks. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches