From: Sergey Organov <sorganov@gmail.com>
To: Walter Harms <wharms@bfs.de>
Cc: David Laight <David.Laight@ACULAB.COM>,
'Dan Carpenter' <dan.carpenter@oracle.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
"Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>,
Jae Hyun Yoo <jae.hyun.yoo@intel.com>,
"John Wang" <wangzhiqiang.bj@bytedance.com>,
Brad Bishop <bradleyb@fuzziesquirrel.com>,
Patrick Venture <venture@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robert Lippert <rlippert@google.com>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: AW: [PATCH] soc: aspeed: fix a ternary sign expansion bug
Date: Fri, 23 Apr 2021 17:40:19 +0300 [thread overview]
Message-ID: <878s59rrn0.fsf@osv.gnss.ru> (raw)
In-Reply-To: <ebe4a1a6dd0748e28e6ca19aec20223e@bfs.de> (Walter Harms's message of "Fri, 23 Apr 2021 11:03:30 +0000")
Walter Harms <wharms@bfs.de> writes:
> as indepentent observer,
> i would go for Dans solution:
>
> ret = kfifo_to_user();
> /* if an error occurs just return */
> if (ret)
> return ret;
>
> /* otherwise return the copied number of bytes */
>
> return copied;
>
> there is no need for any deeper language knowledge,
Yep, but this is not idiomatic C, so one looking at this code would
tend to convert it back to ternary, and the actual problem here is that
the type of 'copied' does not match the return type of the function.
-- Sergey Organov
next prev parent reply other threads:[~2021-04-23 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 9:11 [PATCH] soc: aspeed: fix a ternary sign expansion bug Dan Carpenter
2021-04-22 9:24 ` Al Viro
2021-04-22 9:26 ` Al Viro
2021-04-22 14:56 ` Patrick Venture
2021-04-22 16:21 ` David Laight
2021-04-23 0:07 ` Joel Stanley
2021-04-23 7:43 ` Dan Carpenter
2021-04-23 10:45 ` Sergey Organov
2021-04-23 10:54 ` David Laight
2021-04-23 11:03 ` AW: " Walter Harms
2021-04-23 14:40 ` Sergey Organov [this message]
2021-04-23 14:55 ` David Laight
2021-04-23 15:24 ` Dan Carpenter
2021-04-23 11:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s59rrn0.fsf@osv.gnss.ru \
--to=sorganov@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=andrew@aj.id.au \
--cc=benjaminfair@google.com \
--cc=bradleyb@fuzziesquirrel.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jae.hyun.yoo@intel.com \
--cc=joel@jms.id.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rlippert@google.com \
--cc=venture@google.com \
--cc=wangzhiqiang.bj@bytedance.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).