From: Thomas Gleixner <tglx@linutronix.de>
To: Ira Weiny <ira.weiny@intel.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kmap_local semantics
Date: Wed, 17 Mar 2021 14:59:01 +0100 [thread overview]
Message-ID: <878s6lzxsq.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210312153646.GE3014244@iweiny-DESK2.sc.intel.com>
On Fri, Mar 12 2021 at 07:36, Ira Weiny wrote:
> On Fri, Mar 12, 2021 at 07:54:13AM +0100, Christoph Hellwig wrote:
>> So with the new kmap_local interface is it possible / advisable to
>> use local kmaps over code that might schedule(), e.g. to wait for I/O?
>
> It is possible yes. "Advisable" I think so. Thomas knows better than I what
> performance would be.
The performance impact is only relevant for 32bit machines with HIGHMEM
enabled. On 64bit kmap_local is a NOOP except when you enable
CONFIG_DEBUG_KMAP_LOCAL there which then actually does the mapping (on
x86 only for now) with guard maps between and that will do the 'drop
map' on schedule out and restore on schedule in dance. But for regular
64bit there is absolutely _NO_ overhead.
> FWIW I have been working on converting kmaps to kmap_local. Most of the
> instances don't schedule AFAICT.
The whole point of kmap_local is to be preemptible and does not have the
nasty side effects of kmap_atomic, except for the 1 page per map and map
nesting ordering requirements.
> What I really don't want to see is any kmap'ings handed to another thread. I
> am working hard to eliminate the use of kmap for that use. Is that going to be
> a problem?
kmap != kmap_local
kmap_local mappings are thread local and can't be handed anywhere. It's
documented.
Thanks,
tglx
next prev parent reply other threads:[~2021-03-17 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 6:54 kmap_local semantics Christoph Hellwig
2021-03-12 15:36 ` Ira Weiny
2021-03-17 13:59 ` Thomas Gleixner [this message]
2021-03-18 2:44 ` Ira Weiny
2021-03-18 4:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s6lzxsq.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).