From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C88C433E0 for ; Fri, 17 Jul 2020 06:44:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A85E20704 for ; Fri, 17 Jul 2020 06:44:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbgGQGoN (ORCPT ); Fri, 17 Jul 2020 02:44:13 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:35157 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbgGQGoM (ORCPT ); Fri, 17 Jul 2020 02:44:12 -0400 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id AAB4D1C0008; Fri, 17 Jul 2020 06:44:10 +0000 (UTC) From: Gregory CLEMENT To: "Gustavo A. R. Silva" Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH][next] i2c: mv64xxx: Use fallthrough pseudo-keyword In-Reply-To: <20200716215431.GA19300@embeddedor> References: <20200716215431.GA19300@embeddedor> Date: Fri, 17 Jul 2020 08:44:10 +0200 Message-ID: <878sfi4p51.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Gustavo A. R. Silva" writes: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Gregory CLEMENT > --- > drivers/i2c/busses/i2c-mv64xxx.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c > index 829b8c98ae51..8d9d4ffdcd24 100644 > --- a/drivers/i2c/busses/i2c-mv64xxx.c > +++ b/drivers/i2c/busses/i2c-mv64xxx.c > @@ -251,7 +251,7 @@ mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status) > MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK; > break; > } > - /* FALLTHRU */ > + fallthrough; > case MV64XXX_I2C_STATUS_MAST_WR_ADDR_2_ACK: /* 0xd0 */ > case MV64XXX_I2C_STATUS_MAST_WR_ACK: /* 0x28 */ > if ((drv_data->bytes_left == 0) > @@ -282,14 +282,14 @@ mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status) > MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK; > break; > } > - /* FALLTHRU */ > + fallthrough; > case MV64XXX_I2C_STATUS_MAST_RD_ADDR_2_ACK: /* 0xe0 */ > if (drv_data->bytes_left == 0) { > drv_data->action = MV64XXX_I2C_ACTION_SEND_STOP; > drv_data->state = MV64XXX_I2C_STATE_IDLE; > break; > } > - /* FALLTHRU */ > + fallthrough; > case MV64XXX_I2C_STATUS_MAST_RD_DATA_ACK: /* 0x50 */ > if (status != MV64XXX_I2C_STATUS_MAST_RD_DATA_ACK) > drv_data->action = MV64XXX_I2C_ACTION_CONTINUE; > @@ -417,8 +417,7 @@ mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data) > "mv64xxx_i2c_do_action: Invalid action: %d\n", > drv_data->action); > drv_data->rc = -EIO; > - > - /* FALLTHRU */ > + fallthrough; > case MV64XXX_I2C_ACTION_SEND_STOP: > drv_data->cntl_bits &= ~MV64XXX_I2C_REG_CONTROL_INTEN; > writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_STOP, > -- > 2.27.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com