From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
ajd@linux.ibm.com,
syzbot+1e925b4b836afe85a1c6@syzkaller-ppc64.appspotmail.com,
syzbot+587b2421926808309d21@syzkaller-ppc64.appspotmail.com,
syzbot+58320b7171734bf79d26@syzkaller.appspotmail.com,
syzbot+d6074fb08bdb2e010520@syzkaller.appspotmail.com,
Guenter Roeck <linux@roeck-us.net>,
Daniel Axtens <dja@axtens.net>,
Salvatore Bonaccorso <carnil@debian.org>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2] relay: handle alloc_percpu returning NULL in relay_open
Date: Tue, 26 May 2020 13:25:36 +1000 [thread overview]
Message-ID: <878shffkcv.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <87ftbo232s.fsf@dja-thinkpad.axtens.net>
[ + akpm ]
Daniel Axtens <dja@axtens.net> writes:
>>> > Check if alloc_percpu returns NULL.
>>> >
>>> > This was found by syzkaller both on x86 and powerpc, and the reproducer
>>> > it found on powerpc is capable of hitting the issue as an unprivileged
>>> > user.
>>> >
>>> > Fixes: 017c59c042d0 ("relay: Use per CPU constructs for the relay channel buffer pointers")
>>> > Reported-by: syzbot+1e925b4b836afe85a1c6@syzkaller-ppc64.appspotmail.com
>>> > Reported-by: syzbot+587b2421926808309d21@syzkaller-ppc64.appspotmail.com
>>> > Reported-by: syzbot+58320b7171734bf79d26@syzkaller.appspotmail.com
>>> > Reported-by: syzbot+d6074fb08bdb2e010520@syzkaller.appspotmail.com
>>> > Cc: Akash Goel <akash.goel@intel.com>
>>> > Cc: Andrew Donnellan <ajd@linux.ibm.com> # syzkaller-ppc64
>>> > Reviewed-by: Michael Ellerman <mpe@ellerman.id.au>
>>> > Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
>>> > Cc: stable@vger.kernel.org # v4.10+
>>> > Signed-off-by: Daniel Axtens <dja@axtens.net>
>>>
>>> Acked-by: David Rientjes <rientjes@google.com>
>>
>> It looks this one was never applied (which relates to CVE-2019-19462,
>> as pointed by Guenter in 20191223163610.GA32267@roeck-us.net).
>>
>> Whas this lost or are there any issues pending?
>
> I'm not aware of any pending issues.
>
> (But, if anyone does have any objections I'm happy to revise the patch.)
It looks like kernel/relay.c is lacking a maintainer?
Andrew are you able to pick this up for v5.8? It's pretty obviously
correct, and has David's ack.
Original is here if that helps:
https://lore.kernel.org/lkml/20191219121256.26480-1-dja@axtens.net/
cheers
prev parent reply other threads:[~2020-05-26 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 12:12 [PATCH v2] relay: handle alloc_percpu returning NULL in relay_open Daniel Axtens
2019-12-20 19:00 ` David Rientjes
2020-05-21 15:25 ` Salvatore Bonaccorso
2020-05-25 1:52 ` Daniel Axtens
2020-05-26 3:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878shffkcv.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=carnil@debian.org \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rientjes@google.com \
--cc=syzbot+1e925b4b836afe85a1c6@syzkaller-ppc64.appspotmail.com \
--cc=syzbot+58320b7171734bf79d26@syzkaller.appspotmail.com \
--cc=syzbot+587b2421926808309d21@syzkaller-ppc64.appspotmail.com \
--cc=syzbot+d6074fb08bdb2e010520@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).