From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBDEDC2D0F8 for ; Wed, 13 May 2020 07:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B05F206F5 for ; Wed, 13 May 2020 07:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="sWs5SQCo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730504AbgEMHFM (ORCPT ); Wed, 13 May 2020 03:05:12 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:27330 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729547AbgEMHFJ (ORCPT ); Wed, 13 May 2020 03:05:09 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589353508; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=5BY6ILWQbBBP5bzYtCeFue+FX7NC/WAICZFymNd3smM=; b=sWs5SQCoyZhO0Zx7c5fH79lL+I7K3hPTPQstyhb9uOQQn1t8ljEDAgV8cjlFutPxROg+Y2Dh IeZMCiGKyz4f7z8lQEyazXom7znOtUCkXMKb1ca7j5ULVf2Skt3ey5/niYdcfcj//MD2gDmh tJdE650MBtRlGFliUV4bXcSvk/o= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ebb9c23.7f7e4566c3e8-smtp-out-n03; Wed, 13 May 2020 07:05:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CA574C432C2; Wed, 13 May 2020 07:05:06 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4317FC433D2; Wed, 13 May 2020 07:05:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4317FC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Brian Norris Cc: Navid Emamdoost , emamd001@umn.edu, smccaman@umn.edu, Kangjie Lu , QCA ath9k Development , "David S. Miller" , linux-wireless , "\" , Linux Kernel Subject: Re: [PATCH] ath9k: release allocated buffer if timed out References: <20190906185931.19288-1-navid.emamdoost@gmail.com> Date: Wed, 13 May 2020 10:05:00 +0300 In-Reply-To: (Brian Norris's message of "Tue, 12 May 2020 09:56:47 -0700") Message-ID: <878shwtiw3.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian Norris writes: > On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost > wrote: >> >> In ath9k_wmi_cmd, the allocated network buffer needs to be released >> if timeout happens. Otherwise memory will be leaked. >> >> Signed-off-by: Navid Emamdoost > > I wonder, did you actually test your patches? I ask, because it seems > that all your patches are of the same mechanical variety (produced by > some sort of research project?), and if I look around a bit, I see > several mistakes and regressions noted on your other patches. And > recently, I see someone reporting a 5.4 kernel regression, which looks > a lot like it was caused by this patch: > > https://bugzilla.kernel.org/show_bug.cgi?id=207703#c1 > > I'll propose a revert, if there's no evidence this was actually tested > or otherwise confirmed to fix a real bug. Actually it's already reverted in -next, nobody just realised that it's a regression from commit 728c1e2a05e4: ced21a4c726b ath9k: Fix use-after-free Read in htc_connect_service v5.8-rc1 should be the first release having the fix. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches