From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852F9C43381 for ; Tue, 19 Feb 2019 04:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F651217D7 for ; Tue, 19 Feb 2019 04:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Pon7C6so"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ZXnqq/mu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726144AbfBSEHE (ORCPT ); Mon, 18 Feb 2019 23:07:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50762 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfBSEHD (ORCPT ); Mon, 18 Feb 2019 23:07:03 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3ECF2608D2; Tue, 19 Feb 2019 04:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550549222; bh=uGVscGjQWC/OWhL7Z0iOTmLrqP/qoK8+9ZkjZ8C43BM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Pon7C6somlLT8MvPhjFlnoGcMVaWSSzK0917xz20W7aIlNxIB1QOe9KZV29+mZlTV t1oclUOyWx5h2OoqLLs05Elv12gHi40B3M7O69Efz8byrD0uSkqC7o5YHqtturlNbp jyfH9qC7vWBnbuUc/RjFWElI3iPNfCrktm8oF5QU= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8F703607DE; Tue, 19 Feb 2019 04:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550549221; bh=uGVscGjQWC/OWhL7Z0iOTmLrqP/qoK8+9ZkjZ8C43BM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZXnqq/muos6OXLaGdJKEDSMuxWkMSt5fMt5AiOjzHffWHaINR9QBRRQ9V/cx9OMLz pxj7UO2fOgPNA4pO/jWk/7wtmXJ7XiPfQzP8jRnWvzEoEa5w5bHis+TIGXof08T445 pA8fOkp4+Qwf+Sr3hk8lbntI8nmamfR9JC5VaTV8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8F703607DE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Masahiro Yamada Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , "H . Peter Anvin" , X86 ML , linux-wireless@vger.kernel.org, Christoph Hellwig , "David S. Miller" , Networking , Linux Kernel Mailing List , Lorenzo Bianconi , "moderated list\:ARM\/Mediatek SoC support" , linux-arm-kernel , Felix Fietkau , Matthias Brugger Subject: Re: [PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8() References: <1550469571-25933-1-git-send-email-yamada.masahiro@socionext.com> <1550469571-25933-2-git-send-email-yamada.masahiro@socionext.com> <877edxt1f1.fsf@kamboji.qca.qualcomm.com> <87tvh0syq2.fsf@kamboji.qca.qualcomm.com> <87pnrosy29.fsf@kamboji.qca.qualcomm.com> Date: Tue, 19 Feb 2019 06:06:54 +0200 In-Reply-To: (Masahiro Yamada's message of "Tue, 19 Feb 2019 10:13:27 +0900") Message-ID: <878sycs9pd.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro Yamada writes: > On Tue, Feb 19, 2019 at 4:38 AM Kalle Valo wrote: >> >> Kalle Valo writes: >> >> > Kalle Valo writes: >> > >> >> Masahiro Yamada writes: >> >> >> >>> __sw_hweight8() is just internal implementation. >> >>> >> >>> Drivers should use the common API, hweight8(). >> >>> >> >>> Signed-off-by: Masahiro Yamada >> >> >> >> Acked-by: Kalle Valo >> >> >> >>> This patch should go to x86 tree along with 2/2. >> >>> >> >>> Otherwise, all{yes,mod}config of x86 would be broken. >> >>> >> >>> This patch is trivial enough. >> >>> I want ACK from the net/wireless maintainer >> >>> so that this can go in via x86 tree. >> >> >> >> Sounds good to me, feel free to push via the x86 tree. >> > >> > Actually, can you wait a bit? Felix just reminded me that we have a >> > similar patch pending from Ben Hutchings: >> > >> > https://patchwork.kernel.org/patch/10808203/ >> > >> > And it seems there are two instances of __sw_hweight8, at least in my >> > wireless-drivers-next tree: >> > >> > drivers/net/wireless/mediatek/mt76/mac80211.c: int i, nstream = >> > __sw_hweight8(dev->antenna_mask); >> > drivers/net/wireless/mediatek/mt76/mac80211.c: int n_chains = >> > __sw_hweight8(dev->antenna_mask); >> > >> > So we need to think what to do. >> >> I think the best would be that Felix applies Ben's patch to the wireless >> tree and I'll push it to Linus during the next merge window (via >> net-next). Simpler and less conflicts that way. >> >> So Masahiro, could you hold your x86 patch for a while until the mt76 >> patch will be in Linus' tree? That should not take more than two weeks, >> I think. > > Sure. > I will resend 2/2 later. Great, thanks! -- Kalle Valo