From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755897AbdLVMll (ORCPT ); Fri, 22 Dec 2017 07:41:41 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:38011 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbdLVMlh (ORCPT ); Fri, 22 Dec 2017 07:41:37 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171222124134euoutp014403fe7196457df54a69b6770edd62a8~CnlDKCRVv2143321433euoutp012 X-AuditID: cbfec7f5-f79d06d0000031c7-20-5a3cfd7db2fd From: =?utf-8?Q?=C5=81ukasz_Stelmach?= To: Herbert Xu Cc: Marek Szyprowski , "Andrew F . Davis" , PrasannaKumar Muralidharan , Rob Herring , Matt Mackall , Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver Date: Fri, 22 Dec 2017 13:41:18 +0100 In-reply-to: <20171222083551.GF29663@gondor.apana.org.au> Message-id: <878tdvhr4h.fsf%l.stelmach@samsung.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-version: 1.0 Content-type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRju29nZ2YaTr2n1eakfM4uytEjhlFoGQQd/RNGF3Iwa7aCi22RT yaIwy2s20zTNJGdLoYVzTV0pad4nmU6xHyptatoPbwiaqGna3DHw3/M+z/u8z/t+fFxM2IZ7 cmMUCbRKIY0Tcfhsc+dK79H7f0PEx3SNXuTc1zyC/FBcjZNl7b04+WTKm8wdn8ZIq9VIkCP2 FRY50FDKIYutTSyyqt1GkFqzBpAVuRZApjW2E2ECqr7ERlDmZl/KpM/iUJpaPaA0k0ZAWQY/ sqgF076LhJgfIqPjYpJoVcDpW/zoftMoEa+Bd3KMLawUkOqaDXhcBAPRetUPgsG7UZ+9mpMN +FwhrAAoY6gHY4oFgAaGBx0K1+loXLrH8JUArb3uwZniN0DL+TbnKA48g3Lbm9ib2B0eQe8m dc4mDPZiqCBlCN8U3OBFVFU37TSwoS8a6hh18jx4EnWk9TixAJ5AhT1PwSbe5eDtGhuH4Xei 5ed2ZwAG5Wg+dYPYDEDwDYE2rJ0c5qBzaPbF563j3NCUpXYLe6OszBYWY8gFqK1saUsoAEhX HsbgYLSmz+MwCa4o31yEMfcLUGa6kGmhUNHiDJuhz6K3Y77MS+QAtNhUjT8De0u27VqybdcS hwWDh1B1QwBD+6HK8mmMwaHIYJhjawGuB+50oloeRauD/NVSuTpREeV/Wyk3Acd36l63LH4C FZ2nWgHkApGLwFgfLBbi0iR1srwV7HeM+Wl83wc82Qqlgha5C5K6QsRCgUyafJdWKW+qEuNo dSvw4rJFewSh4vQIIYySJtCxNB1Pq/6rLC7PMwV8CW8a9Zu9EdilzbkiH/8TL5FFzAeJlR6l OSMN9tiwwXD99/oFf0NQs/Xg+UIq26XGMriiWz/Q8rIugzD0R0omLuG/ij1Wu22r/pE+heU1 SgnvoezCjmTTZZ0XjNFW+kzxXuHDfD+f4ccDxPLGtZlHE5JvkusPiqF2LPhqTICIrY6WHj+M qdTSf2Y/CcZWAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsVy+t/xK7o1f22iDFZe0rF4f2oiu8XGGetZ LeYfOcdq0f1KxqL/8Wtmi/PnN7Bb3L/3k8ni8q45bBYzzu9jslh75C67xYJtfYwWS/uPM1q0 7j3C7sDrsXPWXXaPbQdUPTat6mTz6NuyitGj7+UGRo/jN7YzeXzeJBfAHsVlk5Kak1mWWqRv l8CVcXHTA/aCPoGKng0HmRoYm/i6GDk4JARMJPZ+r+5i5AQyxSQu3FvP1sXIxSEksIRR4vfx g4wQzjdGiYfntrGCVLEJ2Ev0H9nHAmKLCOhIrHy5mBWkiFngArPEpq332UCmCgv4STQuiQWp ERKwkDj5og+sl0VAVeLm0QdgNqeApcTR1rNgNq+AscTUs72MILYoUPxe3102iLigxI/J98B2 MQtkS1y4+IZlAiP/LCSpWUhSs4A2MwtoSqzfpQ8R1pZYtvA1M4RtK7Fu3XuWBYysqxhFUkuL c9Nziw31ihNzi0vz0vWS83M3MQKjaNuxn5t3MF7aGHyIUYCDUYmHd8NO6ygh1sSy4srcQ4wq QGMebVh9gVGKJS8/L1VJhLfshE2UEG9KYmVValF+fFFpTmrxIUZpDhYlcd7ePasjhQTSE0tS s1NTC1KLYLJMHJxSwMDnzYg6yN1SqrSx0yb05BvriG/d66I8uox0widWPzae/yvCuGa1WmX/ St3SmJDTPH+4CrbuFn8u1RHvNTk7b7Jt9l2DoEs/l35VqLqaqvFoUn9FT7fd7MNlE9Xm78xW 82DepLs6J8Jl8gHjhCCT2VPTFmu8q+IteqnrpzQpwE2uIDjr79qdSizFGYmGWsxFxYkAqUeu waoCAAA= X-CMS-MailID: 20171222124132eucas1p281d0ae6925ec5358baa3bbbc4e35b628 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171222124132eucas1p281d0ae6925ec5358baa3bbbc4e35b628 X-RootMTR: 20171222124132eucas1p281d0ae6925ec5358baa3bbbc4e35b628 References: <20171222083551.GF29663@gondor.apana.org.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It was <2017-12-22 pi=C4=85 09:35>, when Herbert Xu wrote: > On Fri, Dec 22, 2017 at 09:29:38AM +0100, Marek Szyprowski wrote: >> Hi, >>=20 >> On 2017-12-22 09:24, Herbert Xu wrote: >> >On Mon, Dec 04, 2017 at 01:53:50PM +0100, =C5=81ukasz Stelmach wrote: >> >>Add support for True Random Number Generator found in Samsung Exynos >> >>5250+ SoCs. >> >> >> >>Signed-off-by: =C5=81ukasz Stelmach >> >This doesn't build for me: >> > >> > CC [M] drivers/char/hw_random/exynos-trng.o >> >../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018exynos_rng_= dt_match\u2019 undeclared here (not in a function) >> >../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018__mod_of__e= xynos_rng_dt_match_device_table\u2019 aliased to undefined symbol \u2018exy= nos_rng_dt_match\u2019 >> >make[2]: *** [drivers/char/hw_random/exynos-trng.o] Error 1 >> >make[1]: *** [_module_drivers/char/hw_random] Error 2 >>=20 >> This looks like a missing dependency on "OF" when "COMPILE_TEST" is >> selected. > > Actually it looks like a typo. The variable is actually called > exynos_trng_dt_match as opposed to exynos_rng_dt_match. Indeed. Honestly, I haven't seen this problem, not even once. Right, I have never compiled it as a module. Thanks for spotting. =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJaPP1vAAoJELCuHpyYpYAQZ7YH/38P2/ByWqbh4RAvQ/L3diOt DaQhoivn62rb57snikdvkWaX4QspIUyGFBb1E+bPeFBbVr3Fthq3ZrCqea5fV7ev 6mh+NdjnoGq/bpzZ+uH24uX61MSd2UIICd+l20y7DnoqgrLGW6+q2zrSrWyiijnQ UGSmezEKlhemftRit1wykKkMipr0iHnLYT2aL9PmcqIxTEmh7y85MMk3CgVstt1K 79UXufCcPnmg0AOIrwY2NlrB0XyGPVZXQT54XKy2vzU5drd2BpmIyKZKixbrTZSj 0SMnqhQJESGbARh2LNyop9o1UiWXpqzTjuQRN5HeH37aRYiQHBsQ376JwXYQB8A= =u3N/ -----END PGP SIGNATURE----- --=-=-=--