From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbcHVPQB (ORCPT ); Mon, 22 Aug 2016 11:16:01 -0400 Received: from mga09.intel.com ([134.134.136.24]:27260 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755284AbcHVPQA (ORCPT ); Mon, 22 Aug 2016 11:16:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,560,1464678000"; d="scan'208";a="1018530963" From: Alexander Shishkin To: Mathieu Poirier , peterz@infradead.org Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com, vince@deater.net, mtk.manpages@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V5 0/9] perf: Driver specific configuration for PMU In-Reply-To: <1470932464-726-1-git-send-email-mathieu.poirier@linaro.org> References: <1470932464-726-1-git-send-email-mathieu.poirier@linaro.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 22 Aug 2016 18:15:56 +0300 Message-ID: <878tvon8b7.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu Poirier writes: > As such something that used to be a two-step process: > > # echo 1 > /sys/bus/coresight/devices/20070000.etr/enable_sink > # perf record -e cs_etm//u --per-thread uname > > is integrated in a single command: > > # perf record -e cs_etm/@sink=20070000.etr/u --per-thread uname Can't we simply teach perf record to write 1 to that sysfs attribute and avoid parsing more ascii strings in the kernel? I suspect that would also take way less code. Are there any other use cases for this besides specifying @sink for a ETM? Regards, -- Alex