From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbcEIMVL (ORCPT ); Mon, 9 May 2016 08:21:11 -0400 Received: from mga09.intel.com ([134.134.136.24]:58772 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbcEIMVJ (ORCPT ); Mon, 9 May 2016 08:21:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,600,1455004800"; d="asc'?scan'208";a="975704592" From: Felipe Balbi To: William Wu , gregkh@linuxfoundation.org, heiko@sntech.de Cc: briannorris@google.com, dianders@google.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, frank.wang@rock-chips.com, eddie.cai@rock-chips.com, John.Youn@synopsys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, William Wu Subject: Re: [PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT In-Reply-To: <1462794377-6528-4-git-send-email-william.wu@rock-chips.com> References: <1462794377-6528-1-git-send-email-william.wu@rock-chips.com> <1462794377-6528-4-git-send-email-william.wu@rock-chips.com> User-Agent: Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu) Date: Mon, 09 May 2016 15:18:59 +0300 Message-ID: <878tzj1l1o.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, William Wu writes: > Add snps,phyif_utmi_16_bits devicetree property. USB2 phy this needs a quirk_ prefix... > interface is hardware property, and it's platform dependent, > so we need to configure it in devicetree to set the core to > support a UTMI+ PHY with an 8- or 16-bit interface. > > And refer to the dwc3 databook, the GUSB2PHYCFG.USBTRDTIM > must set to the corresponding value according to the usb2 > phy interface. right, that's fine. But also note on section 8.1.1 Table 8-1 where it states: |-------------+------------------------------------------------------------| | GUSB2PHYCFG | Program the following PHY configuration fields: USBTrdTim, | | | FSIntf, PHYIf, TOUTCal, or leave the default values if | | | the correct power-on values were selected during | | | coreConsultant configuration. Note: The PHY must not | | | be enabled for auto-resume in device mode. Hence the | | | field GUSB2PHYCFG[15] (ULPIAutoRes) must be written | | | with '0' during the power-on initialization in case | | | the reset value is '1'. | | | | |-------------+------------------------------------------------------------| You only need this because your core was badly configured in coreConsultant. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMIAzAAoJEIaOsuA1yqREGQwP/R5jpwe++A4v3TrmWIReqfQ/ 0jgek9adnEl08Tv0cuJyJgVL9C0OKZ2h6UK2Wu3UB14Mo1WZzR0xRjTrNN9bMJoO PW7O/CAU4Of3/CkjfIRRXpate6t+5Z5uIbS2fjoxe4ORE1VQGeqwkHVy6tsKCRs1 p+wjA9YSbFwbhqDlHfk9Gt7pBe3UbhvKqJLtvA40I9JtNrCABqmHt6SXPEuOIpi4 1OKNV05OHtdIRI+h9F44vWWMV/y0bcEal72E7pK6+oJEpYOFva/Vsq16MDRjhFKB ChAXK04bP0Z3D8WTdllE4W3+AAXWkPJ4HV0H7Ut+KnX2BWDF0xnsQIEoe3Yov1+H ZZHN5sSR3cvVVpp6PF5CfD2APuCZIQCPeuPVjW4ovDYrlbsh9rg4utxi+pRdIVsE BPQbIL2zZ42/WHyhqvyLBAE7jlDJL1Nf+tlDlngkCC7+E1zmzy3iZofYZPeWEwYQ c2zn+opBTQYXvnfwv8NBxE6GleSqFYxz1t3INnBVlrnDGonybeKxZk4qEjnWfDNI alIVaP+QPZWGGU7YET3irlKSUoqdtgARzOnqt+GFtfo77MxVHuc7mKfbdxFTakAa TMZIlLOOeXUjF9H8XKnx0Z+Tg2U19eh6UMQW1/HD0RpEFDUMEfI2dCgtSbVgr+sG 5jgaxF2Dp5IRq9gOP8GI =jdQd -----END PGP SIGNATURE----- --=-=-=--