From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbcCABgJ (ORCPT ); Mon, 29 Feb 2016 20:36:09 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:32200 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750760AbcCABgG (ORCPT ); Mon, 29 Feb 2016 20:36:06 -0500 X-IronPort-AV: E=Sophos;i="5.22,521,1449500400"; d="scan'";a="206702066" Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=renesas.com; Message-ID: <878u23j85t.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Mark Brown CC: Stephen Rothwell , Lee Jones , Liam Girdwood , , Subject: Re: linux-next: build failure after merge of the mfd tree In-Reply-To: <87a8mjj8wc.wl%kuninori.morimoto.gx@renesas.com> References: <20160229145122.71636c6b@canb.auug.org.au> <87a8mjj8wc.wl%kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Tue, 1 Mar 2016 01:35:58 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OS1PR01CA0024.jpnprd01.prod.outlook.com (25.161.225.162) To SIXPR06MB1021.apcprd06.prod.outlook.com (25.160.238.156) X-Microsoft-Exchange-Diagnostics: 1;SIXPR06MB1021;2:YPfl38Fa9NAOAZGec9ltTer+RhcsdC4gFu35HAwF9CnBrnapUqpZ+VlzAZuJrAgmSob65XIHhFC5ZqxsTrBmIUHizROk+5VAYEBMRyPkpt8laFEZkOExNWHRVD9L/u0bpj6aiFFdXiMgnaH+yxudRw==;3:LSUdvfMyQRxD9nrNZjmIVhOEXfhnzF3ET7PcJPeTcI0+cW47iAehVThv0PbPprxLEQCcSpcDGmoh3Uex/2xd6Z3kSySZCNPg8EGR4wAEbKFYcHKcyyhQdIuqgoskR9hg;25:yJtXoCI9iiHVtmwkoy77La+w1T3N6M1MoWa5CanaHLwsGpAdqfF3zn03mUn30YIwyA0T1OFjDVTfaC2eyTJEZ0ME10EGViEEwzFQyXfm0dMDnXXzaINYO2XYZSRIVt8MrBK24JQ2O+1I/Fqu0dZQD1P/9ASgdTt9JXd+zOZDHjAJbmrMXsdsD9egK4Vcsj5pDilq4lENVUa88CkskxgwKCd+PltumGw4jm/MtKetWnAoNkwovLLDRxEWnDZBYvzCsBaSJy3ggSvQsF/rlF6KA/UAjOAYuv+zIdHLM591YqS9Z/W6R7TmCXwdNL5ceswAQL5Lr2r9oi7DzFYbRqCIsKe8MDwnfu3/Zcjwxmv8c8Q= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SIXPR06MB1021; X-MS-Office365-Filtering-Correlation-Id: c20d5403-1f96-41e1-e130-08d34171d778 X-Microsoft-Exchange-Diagnostics: 1;SIXPR06MB1021;20:r5Jm4qLa6G3UCL8pckmoXRzhOrGDJe7Csr4b8FUN4DkqbZET7LHiFUkk6Wm+BKs6Elv9/5/oRjXKL9qlenWeporcpEu4zeDoIn90tA/P2rpOuyJAy1qnRMFp6bRNID22RYq88v/2C4hD2ZE8RglOxM5bUhE7vvwqgzurm+NNXuIisoEF61BzQ6x1A6DUZY4fYL9ohmA4E1XObNoA8didyR+uSPAYD8Zn3DRHp2Ipn4gYfqM0leLOiYXJXFc7A0+iqFoGP7WpmPThLCSweDLItVUPFEdSgeNn8WdBT97KLdxpMr4igdpBLYT3Na2DAyXXvWMlXaIbpP2ILhg/rSFjOrBu2qhTICXPeP93fr4cIus/4YNghygE8tdmUC3EUgvlPG3LypGTCIvpIMZF29I7foL0BE7hMPDIgf4XMhfTY6S1E6faYSCXZ+p/VAnXFbLbNFuppLHAuSCkU8alG8JwbANmfJFMnoKKndpvN9t5VDtS0ORxXFtK+ZNMu3tzDyNX;4:CirBxGbnYEL17Vc7W/CPcBfDVwXLCvfNgF+xbpzTgbBp4eWg2GFmLin8fgf5Envx2Pw8oreA1XpeBvNePwIACtACb3vlaT9w0zSlhSdrveoEdICtj4IKu1bFxLqmLA4FO9zNIKYx19Km0cDjKVuTdiOeCY8HLwqldYzYLVrSt6yXymBhFkvrmofq8DsHjwYHsvu3qFPrlOVNBgXk6qfO3aMsKjEQNmO6eLUEG845A3EGgUh2rp79GPOohQ4n5Z9cmDy2ZCXqLpSjmnIuQ70GnCnGmjnwwuk77WTKGuKLKYynN1LUfSQogkruKLYqn17od0sVVbLFOJ8/DxiF0owCZLoMi/zqPRYUhCyNOYEI7kpLqPl12iiRxmWtjunF6JUO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SIXPR06MB1021;BCL:0;PCL:0;RULEID:;SRVR:SIXPR06MB1021; X-Forefront-PRVS: 086831DFB4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(4001350100001)(53416004)(42186005)(50466002)(76176999)(110136002)(5008740100001)(54356999)(19580395003)(83506001)(5004730100002)(50986999)(86362001)(2950100001)(5001960100003)(81156008)(36756003)(92566002)(77096005)(1096002)(87976001)(122386002)(2906002)(46406003)(33646002)(6116002)(66066001)(23726003)(586003)(40100003)(3846002)(189998001)(4326007)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:SIXPR06MB1021;H:morimoto-PC.renesas.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SIXPR06MB1021;23:wdFRIWX3qVDm4XCuzRRMJQJgqk5AqhwY62/wDlvxa?= =?us-ascii?Q?1BQV9a+fVBXbm8D+/gozYZHLTmiKZKGgzFUxuyUqs2E7xfDEvrFi/Ri5WI1m?= =?us-ascii?Q?yiO2oJvO6BEBcU5cQlPN0bYAP4dEgnfEIoUSaTlleQhHWMXxkRPO1O0jhdss?= =?us-ascii?Q?hIiSgOj8X5zWfjJ+5RJ9z9gdsv8IKwQbB9RRcHTeP745qcS24EVzssQS0SqE?= =?us-ascii?Q?swJZQmHy9u0SwIFyizl4vRSQu4yUFfBbXv2z9cFN2xKqM3u1cklhdMhYNHPJ?= =?us-ascii?Q?4LT0OzwjBXTl90nLWnB2eF5rzlT3E3zPOXAzigC+4UbYTDov57FIA106PZLM?= =?us-ascii?Q?kQBR0An1OZA0sQ31Yx2sY5AnpG9156Br2+LP2tdoMGAwzzeJfEbyUY+Z08Fp?= =?us-ascii?Q?PQYapToqXx/lyNJHmmhBZRtvtxpc5hNdd0vj/1W9xK33gablQ/8YvhFrSGFL?= =?us-ascii?Q?+5ioOvmChHClX/M1FVZXoQLShuxlIaqPpjeISxD3CUzdy2gpmiS8PbE365/3?= =?us-ascii?Q?8t8rjHg1k8YiftKVnLTZsGqaEvYyp9HGOOWpdxsbAh2mEEJsbfmY9grXPMFd?= =?us-ascii?Q?9zFcgXUhGZzt46QXGpebCcWGxXsCj4yoadRwL8KFrsUMGynpF2rdlVuJsSlN?= =?us-ascii?Q?U3TZ+LLH+eF2ClJOgZzAXLG4kj9LBYJxYoQkfyqb+wrw+aSwjEqWZ1iMgLdl?= =?us-ascii?Q?mRemAwQV7bqudMMfQ6dqtsFfyalZllHvwYYs8fpZkC3ZaECapuVS44gE2LoX?= =?us-ascii?Q?mLWgf2SrWoPhXewp2TapTraULwb2G2cz2M5H7FDN4ZiD9nElrxc39Gwcnicm?= =?us-ascii?Q?xgl7yYr9dSW3i0TkQ1LPg2tJX1QvDq0aC5esZf4VsB7Ybpi2rgC7YopzpyqF?= =?us-ascii?Q?zYF+YXEntmxTaBCwK0YRZBo9UAWldy4suVfXfj06Wotzkx4uFGEGAtCXtPkQ?= =?us-ascii?Q?PmVtSzRXRlytb7lMpEWxVN2chGJtHN8VDUoQ+oWtS4avNo+EOU/DWvyhYEVF?= =?us-ascii?Q?Is=3D?= X-Microsoft-Exchange-Diagnostics: 1;SIXPR06MB1021;5:+mVPfM7onJINYFRcWpmaBRLKlOgDdx7omrPqn86a0rU6VD+kaDBxwr1VUnuxPlw01e4NY3ZnQMPPXhPVscYg0MpTrrXs8NGUjXfpeOhDoWqRadkH4th+eFq7jwU8SufDGmXTeBk+sAm/Wlu875pgIw==;24:j8sM5jhA6a42iKWGkj7o9sEJxTHat0t+q0+2TWIFhgiYu9A6FydXPC/80BltaaVznmxwe1qaKNMhTU1SMWns+PvjZMvz5k1hTEHp/oAF3ds=;20:4XZ/thSALnso+Rh4/W16twoQEEjoCCFGiRfRKpEMHWa41gksGW7wgdNLsoLZFyiXb5/5XmSjX2DfjfnscKcduYcGV8RMTvuoWd+nw02aJFxZSHP98XQrtrBlfPJURdpcJlPHsxdAGgMkxvGcHbbddYoaUQOBPvADgJD71d3ssi0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2016 01:35:58.3224 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR06MB1021 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark I noticed that you reborned regmap_write_bits() on your latest tree. I think using/adding regmap_force_update_bits() is good idea IMO. Can I create such patch ? > Oops, it is my fault. Can you check/test this patch ? > > ---------------- > From: Kuninori Morimoto > Date: Tue, 1 Mar 2016 10:12:20 +0900 > Subject: [PATCH] regmap: add regmap_force_update_bits() > > commit 23b92e4c ("regmap: remove regmap_write_bits()") > removed regmap_write_bits(), we can use regmap_force_update_bits() > instead of it. > > Signed-off-by: Kuninori Morimoto > --- > drivers/regulator/tps65086-regulator.c | 2 +- > include/linux/regmap.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/regulator/tps65086-regulator.c b/drivers/regulator/tps65086-regulator.c > index 33f389d..e78b688 100644 > --- a/drivers/regulator/tps65086-regulator.c > +++ b/drivers/regulator/tps65086-regulator.c > @@ -191,7 +191,7 @@ static int tps65086_of_parse_cb(struct device_node *dev, > > /* Check for decay mode */ > if (desc->id <= BUCK6 && of_property_read_bool(config->of_node, "ti,regulator-decay")) { > - ret = regmap_write_bits(config->regmap, > + ret = regmap_force_update_bits(config->regmap, > regulators[desc->id].decay_reg, > regulators[desc->id].decay_mask, > regulators[desc->id].decay_mask); > diff --git a/include/linux/regmap.h b/include/linux/regmap.h > index 7449792..d6cde49 100644 > --- a/include/linux/regmap.h > +++ b/include/linux/regmap.h > @@ -67,6 +67,8 @@ struct reg_sequence { > > #define regmap_update_bits(map, reg, mask, val) \ > regmap_update_bits_base(map, reg, mask, val, NULL, false, false) > +#define regmap_force_update_bits(map, reg, mask, val) \ > + regmap_update_bits_base(map, reg, mask, val, NULL, false, true) > #define regmap_update_bits_async(map, reg, mask, val)\ > regmap_update_bits_base(map, reg, mask, val, NULL, true, false) > #define regmap_update_bits_check(map, reg, mask, val, change)\ > -- > ---------------- > > > Best regards > --- > Kuninori Morimoto