From: Romain Francoise <romain@orebokech.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Mathias Krause <minipli@googlemail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: Linux 3.6-rc5
Date: Mon, 10 Sep 2012 19:18:17 +0200 [thread overview]
Message-ID: <878vchdcfa.fsf@silenus.orebokech.com> (raw)
In-Reply-To: <20120909210000.GA10293@gondor.apana.org.au> (Herbert Xu's message of "Sun, 9 Sep 2012 14:00:00 -0700")
Herbert Xu <herbert@gondor.apana.org.au> writes:
> Thanks! I think this patch should fix the problem. Can someone
> please confirm this?
Works for me as well, thanks!
> crypto: authenc - Fix crash with zero-length assoc data
>
> The authenc code doesn't deal with zero-length associated data
> correctly and ends up constructing a zero-length sg entry which
> causes a crash when it's fed into the crypto system.
>
> This patch fixes this by avoiding the code-path that triggers
> the SG construction if we have no associated data.
>
> This isn't the most optimal fix as it means that we'll end up
> using the fallback code-path even when we could still execute
> the digest function. However, this isn't a big deal as nobody
> but the test path would supply zero-length associated data.
>
> Reported-by: Romain Francoise <romain@orebokech.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Feel free to change this to:
Reported-and-tested-by: Romain Francoise <romain@orebokech.com>
next prev parent reply other threads:[~2012-09-10 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 0:18 Linux 3.6-rc5 Linus Torvalds
2012-09-09 9:13 ` Romain Francoise
2012-09-09 12:54 ` Jussi Kivilinna
2012-09-09 14:23 ` Romain Francoise
2012-09-09 15:35 ` Linus Torvalds
2012-09-09 18:53 ` Herbert Xu
2012-09-09 20:54 ` Jussi Kivilinna
2012-09-09 21:01 ` Herbert Xu
2012-09-09 19:19 ` Herbert Xu
2012-09-09 20:09 ` Mathias Krause
2012-09-09 21:00 ` Herbert Xu
2012-09-09 21:09 ` Mathias Krause
2012-09-10 17:18 ` Romain Francoise [this message]
2012-09-09 20:26 ` Jussi Kivilinna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vchdcfa.fsf@silenus.orebokech.com \
--to=romain@orebokech.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).