From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAFDC433F5 for ; Wed, 20 Apr 2022 22:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353504AbiDTWP2 (ORCPT ); Wed, 20 Apr 2022 18:15:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355967AbiDTWO5 (ORCPT ); Wed, 20 Apr 2022 18:14:57 -0400 Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 671B248E68 for ; Wed, 20 Apr 2022 15:11:49 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4KkFJD0kZCz1r0PY; Thu, 21 Apr 2022 00:11:40 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4KkFJC5Cqvz1qqkB; Thu, 21 Apr 2022 00:11:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 3mtlwbvpiYJD; Thu, 21 Apr 2022 00:11:38 +0200 (CEST) X-Auth-Info: 8HbkyrIVus8sGoHUetusB0Obnv7jg/sLKvDsDI9Z4rWZKW80iKNKFlX3jwZgpAnd Received: from igel.home (ppp-46-244-167-235.dynamic.mnet-online.de [46.244.167.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 21 Apr 2022 00:11:38 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id B225C2C3AC9; Thu, 21 Apr 2022 00:11:37 +0200 (CEST) From: Andreas Schwab To: Palmer Dabbelt Cc: linux-riscv@lists.infradead.org, rdunlap@infradead.org, Paul Walmsley , Palmer Dabbelt , aou@eecs.berkeley.edu, anup@brainfault.org, vincent.chen@sifive.com, guoren@kernel.org, Atish Patra , alexandre.ghiti@canonical.com, jszhang@kernel.org, vitaly.wool@konsulko.com, gatecat@ds0.me, wangkefeng.wang@huawei.com, mick@ics.forth.gr, panqinglin2020@iscas.ac.cn, rppt@kernel.org, linux-kernel@vger.kernel.org, linux@rivosinc.com, kernel test robot Subject: Re: [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions References: <20220420184056.7886-1-palmer@rivosinc.com> <20220420184056.7886-2-palmer@rivosinc.com> X-Yow: If I am elected, the concrete barriers around the WHITE HOUSE will be replaced by tasteful foam replicas of ANN MARGARET! Date: Thu, 21 Apr 2022 00:11:37 +0200 In-Reply-To: <20220420184056.7886-2-palmer@rivosinc.com> (Palmer Dabbelt's message of "Wed, 20 Apr 2022 11:40:53 -0700") Message-ID: <87a6cfh0bq.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Apr 20 2022, Palmer Dabbelt wrote: > (create_pmd_mpping() ends up skipped on XIP_KERNEL). Does it? There is always the semicolon left as the body of the conditional (which is why you get the empty-body warning in the first place). -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."