archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <>
To: Peter Zijlstra <>,
	Sebastian Andrzej Siewior <>
Cc:, Ben Skeggs <>,
	Mike Galbraith <>,
	Greg Kroah-Hartman <>
Subject: Re: [PATCH 1/2] kthread: Move prio/affinite change into the newly created thread
Date: Sat, 21 Nov 2020 11:55:48 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Nov 17 2020 at 13:45, Peter Zijlstra wrote:
> On Tue, Nov 10, 2020 at 12:38:47PM +0100, Sebastian Andrzej Siewior wrote:
> Moo... yes this is certainly the easiest solution, because nouveau is a
> horrible rats nest. But when I spoke to Greg KH about this, he suggested
> nouveau ought to be fixed.
> Ben, I got terminally lost when trying to untangle nouvea init, is there
> any chance this can be fixed to not hold that nvkm_device::mutex thing
> while doing request_irq() ?

OTOH, creating a dependency chain vs. cpuset_rwsem and whatever lock is
held by the caller via request_irq() or kthread_create() is not
necessarily restricted to the nivea driver. struct device::mutex (not
the nkvm_device::mutex) is always held when a driver is probed.

The cpuset_rwsem -> mmap_lock dependency is a given, so we're one step
away from a circular dependency vs. mmap_lock.

That was my reasoning to move the stuff out into the thread context.



  parent reply	other threads:[~2020-11-21 10:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 11:38 [PATCH 0/2] genirq: Move prio assignment " Sebastian Andrzej Siewior
2020-11-10 11:38 ` [PATCH 1/2] kthread: Move prio/affinite change " Sebastian Andrzej Siewior
2020-11-17 12:45   ` Peter Zijlstra
2020-11-20 22:17     ` Sebastian Andrzej Siewior
2020-11-21 10:55     ` Thomas Gleixner [this message]
2021-03-03 16:25       ` Sebastian Andrzej Siewior
2020-11-10 11:38 ` [PATCH 2/2] genirq: Move prio assignment " Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] kthread: Move prio/affinite change into the newly created thread' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).