From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E92C43467 for ; Wed, 14 Oct 2020 08:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2942A214D8 for ; Wed, 14 Oct 2020 08:46:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="m2WQrD/h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730069AbgJNIqT (ORCPT ); Wed, 14 Oct 2020 04:46:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730040AbgJNIqR (ORCPT ); Wed, 14 Oct 2020 04:46:17 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2E2CC051112 for ; Wed, 14 Oct 2020 01:46:16 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id y16so2341092ljk.1 for ; Wed, 14 Oct 2020 01:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=WZzAvEzx83nvmn1jnQ1JsHRh7Bwi7GkshJQjuaqNhd8=; b=m2WQrD/hdTD5LjbHDAwGuoYOIGT0qzS7Rh2cRUH6c+z59FC5L21sfBT+CFxcdFn3rm yeIaHgqk+FbRNeIpMhUpqb0rxxrLN9Jp4j8eHxTKDq6naLPsInM3Rq8eMvRTuUBxL4uP 2hRzm12E82CCk8DrGd4TgC2L4Kao7gMIGdvCA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=WZzAvEzx83nvmn1jnQ1JsHRh7Bwi7GkshJQjuaqNhd8=; b=sO1bkY6oUFdzdiDYsB4FlK9t0MWH3jQGAcTROB23CN56d9hpxmt2DaVDvFmOwJc9dh sPJrQ2FLCH4Jxwy6r7hlRfSr2cH5YaFJRL2A4UR5cTqMDY+NiKTASJnvQlmCamFd+6py mqek/UDHWd3buYKQEMQ0O8o9expXnaTsk9Y2ZckW6xjEvUmAtsiLLi3q6Xd4Ywbn5haz X0f+49uIwVmbC1ZST2DuMU6+bfKrj5OuYQCEFxL2dCrLymujVZPDB5VuAw1DU3SmG4Pu 9LIA3RLTMHSIfea9Cmu2HCFsU5A7Wk3h884PWSVvIvckOWaAPd3PzHCfcdFRh+aabC9H dHAg== X-Gm-Message-State: AOAM531kPzm+kghJW+2kLuQGClLfbNQoWUGwNwtlH3sztXktcyTfTHx+ 7DYnQPQazUlCiq3lJNY6omg8YA== X-Google-Smtp-Source: ABdhPJwNpOAovNBhBYsFFDCiT34RRRcmevp3KQV8NZfuMYOl1uJJgvCOlNTAqwDR86oS5iVlVzy8sQ== X-Received: by 2002:a2e:9d93:: with SMTP id c19mr1525646ljj.32.1602665175249; Wed, 14 Oct 2020 01:46:15 -0700 (PDT) Received: from cloudflare.com ([2a02:a310:c262:aa00:b35e:8938:2c2a:ba8b]) by smtp.gmail.com with ESMTPSA id l188sm890871lfd.127.2020.10.14.01.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 01:46:14 -0700 (PDT) References: <20201012091850.67452-1-lmb@cloudflare.com> User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Lorenz Bauer Cc: John Fastabend , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Yonghong Song , kernel-team@cloudflare.com, kernel test robot , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf] bpf: sockmap: add locking annotations to iterator In-reply-to: <20201012091850.67452-1-lmb@cloudflare.com> Date: Wed, 14 Oct 2020 10:46:13 +0200 Message-ID: <87a6wpqjoq.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 11:18 AM CEST, Lorenz Bauer wrote: > The sparse checker currently outputs the following warnings: > > include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_hash_seq_start' - wrong count at exit > include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_map_seq_start' - wrong count at exit > > Add the necessary __acquires and __release annotations to make the > iterator locking schema palatable to sparse. Also add __must_hold > for good measure. > > The kernel codebase uses both __acquires(rcu) and __acquires(RCU). > I couldn't find any guidance which one is preferred, so I used > what is easier to type out. > > Fixes: 0365351524d7 ("net: Allow iterating sockmap and sockhash") > Reported-by: kernel test robot > Signed-off-by: Lorenz Bauer > --- Acked-by: Jakub Sitnicki