From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Tero Kristo" <t-kristo@ti.com>, "Nishanth Menon" <nm@ti.com>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v3 14/15] ARM: dts: armada: align GPIO hog names with dtschema
Date: Wed, 23 Sep 2020 16:39:02 +0200 [thread overview]
Message-ID: <87a6xgimm1.fsf@BL-laptop> (raw)
In-Reply-To: <20200916155715.21009-15-krzk@kernel.org>
Hi Krzysztof,
> The convention for node names is to use hyphens, not underscores.
> dtschema for pca95xx expects GPIO hogs to end with 'hog' prefix.
Applied on mvebu/dt
Thanks,
Gregory
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/armada-388-clearfog.dts | 4 ++--
> arch/arm/boot/dts/armada-388-clearfog.dtsi | 10 +++++-----
> arch/arm/boot/dts/armada-388-helios4.dts | 6 +++---
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
> index 20f8d4667753..4140a5303b48 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dts
> @@ -73,13 +73,13 @@
> * 14-SFP_TX_DISABLE
> * 15-SFP_MOD_DEF0
> */
> - pcie2_0_clkreq {
> + pcie2-0-clkreq-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_LOW>;
> input;
> line-name = "pcie2.0-clkreq";
> };
> - pcie2_0_w_disable {
> + pcie2-0-w-disable-hog {
> gpio-hog;
> gpios = <7 GPIO_ACTIVE_LOW>;
> output-low;
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dtsi b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> index a0aa1d188f0c..f8a06ae4a3c9 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dtsi
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> @@ -141,31 +141,31 @@
> #gpio-cells = <2>;
> reg = <0x20>;
>
> - pcie1_0_clkreq {
> + pcie1-0-clkreq-hog {
> gpio-hog;
> gpios = <0 GPIO_ACTIVE_LOW>;
> input;
> line-name = "pcie1.0-clkreq";
> };
> - pcie1_0_w_disable {
> + pcie1-0-w-disable-hog {
> gpio-hog;
> gpios = <3 GPIO_ACTIVE_LOW>;
> output-low;
> line-name = "pcie1.0-w-disable";
> };
> - usb3_ilimit {
> + usb3-ilimit-hog {
> gpio-hog;
> gpios = <5 GPIO_ACTIVE_LOW>;
> input;
> line-name = "usb3-current-limit";
> };
> - usb3_power {
> + usb3-power-hog {
> gpio-hog;
> gpios = <6 GPIO_ACTIVE_HIGH>;
> output-high;
> line-name = "usb3-power";
> };
> - m2_devslp {
> + m2-devslp-hog {
> gpio-hog;
> gpios = <11 GPIO_ACTIVE_HIGH>;
> output-low;
> diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
> index fb49df2a3bce..b3728de3bd3f 100644
> --- a/arch/arm/boot/dts/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/armada-388-helios4.dts
> @@ -166,19 +166,19 @@
> interrupt-controller;
> #interrupt-cells = <2>;
>
> - board_rev_bit_0 {
> + board-rev-bit-0-hog {
> gpio-hog;
> gpios = <0 GPIO_ACTIVE_LOW>;
> input;
> line-name = "board-rev-0";
> };
> - board_rev_bit_1 {
> + board-rev-bit-1-hog {
> gpio-hog;
> gpios = <1 GPIO_ACTIVE_LOW>;
> input;
> line-name = "board-rev-1";
> };
> - usb3_ilimit {
> + usb3-ilimit-hog {
> gpio-hog;
> gpios = <5 GPIO_ACTIVE_HIGH>;
> input;
> --
> 2.17.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2020-09-23 14:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 15:57 [PATCH v3 00/15] ARM: dts: / gpio: Add dtschema for NXP PCA953x and correct dts Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema Krzysztof Kozlowski
2020-09-25 15:48 ` Krzysztof Kozlowski
2020-09-29 12:03 ` Linus Walleij
2020-09-16 15:57 ` [PATCH v3 02/15] dt-bindings: gpio: convert bindings for Maxim MAX732x " Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 03/15] arm64: dts: mediatek: fix tca6416 reset GPIOs in pumpkin Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 04/15] arm64: dts: mediatek: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 05/15] arm64: dts: renesas: " Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 06/15] arm64: dts: ti: " Krzysztof Kozlowski
2020-09-25 12:01 ` Nishanth Menon
2020-09-16 15:57 ` [PATCH v3 07/15] arm64: dts: xilinx: " Krzysztof Kozlowski
2020-09-29 10:54 ` Michal Simek
2020-09-16 15:57 ` [PATCH v3 08/15] ARM: dts: am335x: lxm: fix PCA9539 GPIO expander properties Krzysztof Kozlowski
2020-09-25 11:36 ` Tony Lindgren
2020-09-16 15:57 ` [PATCH v3 09/15] ARM: dts: am335x: t335: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-25 11:37 ` Tony Lindgren
2020-09-16 15:57 ` [PATCH v3 10/15] ARM: dts: am3874: iceboard: fix GPIO expander reset GPIOs Krzysztof Kozlowski
2020-09-25 11:38 ` Tony Lindgren
2020-09-16 15:57 ` [PATCH v3 11/15] ARM: dts: aspeed: fix PCA95xx GPIO expander properties on Portwell Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 12/15] ARM: dts: aspeed: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-16 15:57 ` [PATCH v3 13/15] ARM: dts: dove: fix PCA95xx GPIO expander properties on A510 Krzysztof Kozlowski
2020-09-23 14:38 ` Gregory CLEMENT
2020-09-16 15:57 ` [PATCH v3 14/15] ARM: dts: armada: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-23 14:39 ` Gregory CLEMENT [this message]
2020-09-16 15:57 ` [PATCH v3 15/15] ARM: dts: imx6q: " Krzysztof Kozlowski
2020-09-22 2:00 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6xgimm1.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).