From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4754C433E0 for ; Fri, 15 May 2020 08:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3122206B6 for ; Fri, 15 May 2020 08:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbgEOIxB (ORCPT ); Fri, 15 May 2020 04:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727116AbgEOIxB (ORCPT ); Fri, 15 May 2020 04:53:01 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A864C061A0C for ; Fri, 15 May 2020 01:53:01 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jZW4l-0002zr-RB; Fri, 15 May 2020 10:52:16 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 19CA8100606; Fri, 15 May 2020 10:52:15 +0200 (CEST) From: Thomas Gleixner To: Boris Ostrovsky , LKML Cc: x86@kernel.org, "Paul E. McKenney" , Andy Lutomirski , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon , Tom Lendacky , Wei Liu , Michael Kelley , Jason Chen CJ , Zhao Yakui , "Peter Zijlstra \(Intel\)" Subject: Re: [patch V5 24/38] x86/entry: Provide IDTENTRY_SYSVEC In-Reply-To: <78bf7499-b810-4e71-46c0-3d86f6c6d3d7@oracle.com> References: <20200512210059.056244513@linutronix.de> <20200512213811.844041484@linutronix.de> <78bf7499-b810-4e71-46c0-3d86f6c6d3d7@oracle.com> Date: Fri, 15 May 2020 10:52:15 +0200 Message-ID: <87a729y400.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Boris Ostrovsky writes: > On 5/12/20 5:01 PM, Thomas Gleixner wrote: >> + >> +/** >> + * DEFINE_IDTENTRY_SYSVEC - Emit code for system vector IDT entry points >> + * @func: Function name of the entry point >> + * >> + * idtentry_enter/exit() and irq_enter/exit_rcu() are invoked before the >> + * function body. KVM L1D flush request is set. > > > This is used for entry points for Xen and hyperV as well. Even though > it's harmless at the moment, do we still want to set this flag for non-KVM? Right, it's pointless for !KVM, but we have set this unconditionally since the l1tf mess was introduced. I'm not sure whether it's worth to optimize the single store out. Thanks, tglx