From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D5CEC10DCE for ; Thu, 12 Mar 2020 23:32:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E3D3206FA for ; Thu, 12 Mar 2020 23:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726922AbgCLXcl convert rfc822-to-8bit (ORCPT ); Thu, 12 Mar 2020 19:32:41 -0400 Received: from mga03.intel.com ([134.134.136.65]:11238 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbgCLXck (ORCPT ); Thu, 12 Mar 2020 19:32:40 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 16:32:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,546,1574150400"; d="scan'208";a="444116838" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.54.70.26]) by fmsmga006.fm.intel.com with ESMTP; 12 Mar 2020 16:32:38 -0700 From: Vinicius Costa Gomes To: Po Liu , "davem\@davemloft.net" , "hauke.mehrtens\@intel.com" , "gregkh\@linuxfoundation.org" , "allison\@lohutok.net" , "tglx\@linutronix.de" , "hkallweit1\@gmail.com" , "saeedm\@mellanox.com" , "andrew\@lunn.ch" , "f.fainelli\@gmail.com" , "alexandru.ardelean\@analog.com" , "jiri\@mellanox.com" , "ayal\@mellanox.com" , "pablo\@netfilter.org" , "linux-kernel\@vger.kernel.org" , "netdev\@vger.kernel.org" Cc: "simon.horman\@netronome.com" , Claudiu Manoil , Vladimir Oltean , Alexandru Marginean , Xiaoliang Yang , Roy Zang , Mingkai Hu , Jerry Huang , Leo Li , Murali Karicheri , Ivan Khoronzhuk Subject: RE: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes In-Reply-To: References: <20191127094517.6255-1-Po.Liu@nxp.com> <87a75br4ze.fsf@linux.intel.com> Date: Thu, 12 Mar 2020 16:34:50 -0700 Message-ID: <87a74lgnad.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Po Liu writes: > Hi Vinicius, > > > Br, > Po Liu > >> -----Original Message----- >> From: Vinicius Costa Gomes >> Sent: 2020年2月22日 5:44 >> To: Po Liu ; davem@davemloft.net; >> hauke.mehrtens@intel.com; gregkh@linuxfoundation.org; allison@lohutok.net; >> tglx@linutronix.de; hkallweit1@gmail.com; saeedm@mellanox.com; >> andrew@lunn.ch; f.fainelli@gmail.com; alexandru.ardelean@analog.com; >> jiri@mellanox.com; ayal@mellanox.com; pablo@netfilter.org; linux- >> kernel@vger.kernel.org; netdev@vger.kernel.org >> Cc: simon.horman@netronome.com; Claudiu Manoil >> ; Vladimir Oltean ; >> Alexandru Marginean ; Xiaoliang Yang >> ; Roy Zang ; Mingkai Hu >> ; Jerry Huang ; Leo Li >> ; Po Liu >> Subject: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of >> traffic classes >> >> Caution: EXT Email >> >> Hi, >> >> Po Liu writes: >> >> > IEEE Std 802.1Qbu standard defined the frame preemption of port >> > traffic classes. This patch introduce a method to set traffic classes >> > preemption. Add a parameter 'preemption' in struct >> > ethtool_link_settings. The value will be translated to a binary, each >> > bit represent a traffic class. Bit "1" means preemptable traffic >> > class. Bit "0" means express traffic class. MSB represent high number >> > traffic class. >> > >> > If hardware support the frame preemption, driver could set the >> > ethernet device with hw_features and features with NETIF_F_PREEMPTION >> > when initializing the port driver. >> > >> > User can check the feature 'tx-preemption' by command 'ethtool -k >> > devname'. If hareware set preemption feature. The property would be a >> > fixed value 'on' if hardware support the frame preemption. >> > Feature would show a fixed value 'off' if hardware don't support the >> > frame preemption. >> > >> > Command 'ethtool devname' and 'ethtool -s devname preemption N' >> > would show/set which traffic classes are frame preemptable. >> > >> > Port driver would implement the frame preemption in the function >> > get_link_ksettings() and set_link_ksettings() in the struct ethtool_ops. >> > >> >> Any updates on this series? If you think that there's something that I could help, >> just tell. > > Sorry for the long time not involve the discussion. I am focus on other tsn code for tc flower. > If you can take more about this preemption serial, that would be good. > > I summary some suggestions from Marali Karicheri and Ivan Khornonzhuk and by you and also others: > - Add config the fragment size, hold advance, release advance and flags; > My comments about the fragment size is in the Qbu spec limit the fragment size " the minimum non-final fragment size is 64, > 128, 192, or 256 octets " this setting would affect the guardband setting for Qbv. But the ethtool setting could not involve this issues but by the taprio side. > - " Furthermore, this setting could be extend for a serial setting for mac and traffic class." "Better not to using the traffic class concept." > Could adding a serial setting by "ethtool --preemption xxx" or other name. I don' t think it is good to involve in the queue control since queues number may bigger than the TC number. > - The ethtool is the better choice to configure the preemption > I agree. Just a quick update. I was able to dedicate some time to this, and have something aproaching RFC-quality, but it needs more testing. So, question, what were you using for testing this? Anything special? And btw, thanks for the summary of the discussion. > > Thanks！ >> >> >> Cheers, >> -- >> Vinicius -- Vinicius