From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3053C433FF for ; Wed, 14 Aug 2019 12:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF7C92084D for ; Wed, 14 Aug 2019 12:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbfHNMnm (ORCPT ); Wed, 14 Aug 2019 08:43:42 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56195 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727650AbfHNMnm (ORCPT ); Wed, 14 Aug 2019 08:43:42 -0400 Received: by mail-wm1-f68.google.com with SMTP id f72so4481507wmf.5 for ; Wed, 14 Aug 2019 05:43:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+/1vKYXrSmMiEh34sDlj/esL/DhVL71JkebODZigBoQ=; b=L1HE2ehliXYbgtnJPS6uvtKLu8FNpwgsf0BNm1bnvnKinhmpu5p4IQdySTrLZ2ecOr ty6ipaRLjlWY/UeMzOn6LlIulBPf+BrF4z2coZV/xcby0CXL/A9WNzfl67g2IyALH0CK AsmXlZDZ1w1AHoIJNVbiIY7d8wSIKk0oqLoUwfXbqWmS5dxoX3TuyFp73hyjKs050CfE lbV9/xj/0zoqBJPXzxUFNOELvbgR96HFSHeFTTLIJf6CZFFKYoWUikKvhX7mwDL0IuSk apyKErdZGnY0BUj4WhJObtW6HInZGs6+pPU00fDuqB8K+3gVJ0fXf1/0QTYxoQNS2le2 ySYQ== X-Gm-Message-State: APjAAAW47lmz9wIJazFmGt7jFuY5Kwz08ukgtsb+9V13zJspxC1gHs2v KUKyXsFI+tZ/EjkC3oBpYBXkTg== X-Google-Smtp-Source: APXvYqzzDAT9Sp0tyjPx2rBW0LPqA0/D9z0qNyAJbXa5Bd2dw94Fua3CJ4aiCqDB6gsk6UPMeEPDdw== X-Received: by 2002:a7b:c383:: with SMTP id s3mr8408422wmj.44.1565786620557; Wed, 14 Aug 2019 05:43:40 -0700 (PDT) Received: from vitty.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id f197sm9387049wme.22.2019.08.14.05.43.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 05:43:39 -0700 (PDT) From: Vitaly Kuznetsov To: Yang Weijiang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mst@redhat.com, rkrcmar@redhat.com, jmattson@google.com, yu.c.zhang@intel.com, alazar@bitdefender.com, Yang Weijiang , pbonzini@redhat.com, sean.j.christopherson@intel.com Subject: Re: [PATCH RESEND v4 5/9] KVM: VMX: Add init/set/get functions for SPP In-Reply-To: <20190814070403.6588-6-weijiang.yang@intel.com> References: <20190814070403.6588-1-weijiang.yang@intel.com> <20190814070403.6588-6-weijiang.yang@intel.com> Date: Wed, 14 Aug 2019 14:43:39 +0200 Message-ID: <87a7cbapdw.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yang Weijiang writes: > init_spp() must be called before {get, set}_subpage > functions, it creates subpage access bitmaps for memory pages > and issues a KVM request to setup SPPT root pages. > > kvm_mmu_set_subpages() is to enable SPP bit in EPT leaf page > and setup corresponding SPPT entries. The mmu_lock > is held before above operation. If it's called in EPT fault and > SPPT mis-config induced handler, mmu_lock is acquired outside > the function, otherwise, it's acquired inside it. > > kvm_mmu_get_subpages() is used to query access bitmap for > protected page, it's also used in EPT fault handler to check > whether the fault EPT page is SPP protected as well. > > Co-developed-by: He Chen > Signed-off-by: He Chen > Co-developed-by: Zhang Yi > Signed-off-by: Zhang Yi > Signed-off-by: Yang Weijiang > --- > arch/x86/include/asm/kvm_host.h | 18 ++++ > arch/x86/include/asm/vmx.h | 2 + > arch/x86/kvm/mmu.c | 160 ++++++++++++++++++++++++++++++++ > arch/x86/kvm/vmx/vmx.c | 48 ++++++++++ > arch/x86/kvm/x86.c | 40 ++++++++ > include/linux/kvm_host.h | 4 +- > include/uapi/linux/kvm.h | 9 ++ > 7 files changed, 280 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 44f6e1757861..5c4882015acc 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -398,8 +398,13 @@ struct kvm_mmu { > void (*invlpg)(struct kvm_vcpu *vcpu, gva_t gva, hpa_t root_hpa); > void (*update_pte)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp, > u64 *spte, const void *pte); > + int (*get_subpages)(struct kvm *kvm, struct kvm_subpage *spp_info); > + int (*set_subpages)(struct kvm *kvm, struct kvm_subpage *spp_info); > + int (*init_spp)(struct kvm *kvm); > + > hpa_t root_hpa; > gpa_t root_cr3; > + hpa_t sppt_root; (I'm sorry if this was previously discussed, I didn't look into previous submissions). What happens when we launch a nested guest and switch vcpu->arch.mmu to point at arch.guest_mmu? sppt_root will point to INVALID_PAGE and SPP won't be enabled in VMCS? (I'm sorry again, I'm likely missing something obvious) -- Vitaly