From: Nathan Lynch <nathanl@linux.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag
Date: Wed, 24 Apr 2019 08:45:31 -0500 [thread overview]
Message-ID: <87a7gfseis.fsf@linux.ibm.com> (raw)
In-Reply-To: <CAK8P3a3At0Znn7BRxVxFdxcCa2=uJ9fAJYazKe3E9688axPj2g@mail.gmail.com>
Arnd Bergmann <arnd@arndb.de> writes:
> On Mon, Dec 10, 2018 at 11:32 PM <ndesaulniers@google.com> wrote:
>>
>> GNU linker's -z common-page-size's default value is based on the target
>> architecture. arch/arm/vdso/Makefile sets it to the architecture
>> default, which is implicit and redundant. Drop it.
>>
>> Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>> ---
>
> The patch looks good to me,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Adding Nathan Lynch to Cc though for further comments, he originally
> added the Makefile flags here and might still remember why he did it.
>
> Unless Nathan objects, please add the patch to Russell's patch
> tracker.
Thanks for cc'ing me -- no objection.
Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
next prev parent reply other threads:[~2019-04-24 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 22:31 [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag ndesaulniers
2019-01-14 21:50 ` Nick Desaulniers
2019-04-24 7:29 ` Arnd Bergmann
2019-04-24 13:45 ` Nathan Lynch [this message]
2019-04-24 18:12 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7gfseis.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).