From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Sasha Levin <sashal@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
devel@linuxdriverproject.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
linux-kernel@vger.kernel.org, Dexuan Cui <decui@microsoft.com>
Subject: Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining
Date: Mon, 07 Jan 2019 19:38:20 +0100 [thread overview]
Message-ID: <87a7kc2u03.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20190107175650.GG166797@sasha-vm>
Sasha Levin <sashal@kernel.org> writes:
> On Mon, Jan 07, 2019 at 02:44:30PM +0100, Vitaly Kuznetsov wrote:
>>P.S. I still think about bringing mem_hotplug_begin()/done() to
>>hv_balloon but that's going to be a separate discussion, here I want to
>>have a small fix backportable to stable.
>
> This should probably be marked for stable then :)
>
Yes, please :-)
I didn't test old kernels but this seems to be an old issue,
e.g. DEFERRED_STRUCT_PAGE_INIT appeared in 4.2 - not sure if memory
hotplug code was using it back then but, oh well, it's all history now.
(I remember Greg disliked when people were tagging patches for stable@
themselves, he prefered maintainers deciding if the particular commit
deserves stable@ or not - but as you have a tree now we may as well have
different rules :-)
--
Vitaly
next prev parent reply other threads:[~2019-01-07 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 14:19 [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining Vitaly Kuznetsov
2019-01-07 10:21 ` David Hildenbrand
2019-01-07 13:44 ` Vitaly Kuznetsov
2019-01-07 17:56 ` Sasha Levin
2019-01-07 18:38 ` Vitaly Kuznetsov [this message]
2019-01-08 6:41 ` Greg KH
2019-01-08 9:47 ` Dan Carpenter
2019-01-08 14:34 ` Vitaly Kuznetsov
2019-01-08 21:23 ` Sasha Levin
2019-01-08 9:15 ` David Hildenbrand
2019-01-08 9:42 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7kc2u03.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=david@redhat.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).