From: Kalle Valo <kvalo@codeaurora.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
Richard Weinberger <richard.weinberger@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH] bug: Exclude non-BUG/WARN exceptions from report_bug()
Date: Mon, 05 Mar 2018 07:52:23 +0200 [thread overview]
Message-ID: <87a7vn9ii0.fsf@purkki.adurom.net> (raw)
In-Reply-To: <CA+55aFwPZdYGQaEww_wPM_AibQ7tpNSXXAQpKkbgBQRrYN2WZA@mail.gmail.com> (Linus Torvalds's message of "Fri, 2 Mar 2018 13:23:27 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Fri, Mar 2, 2018 at 12:22 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> My question would be, will the existing automated systems that parse
>> the "PATCH" subject deal with a non-whitespaced suffix like this?
>
> Hmm. Maybe just space them out. That's what networking already does,
> ie you'll see things like
>
> [PATCH net-next v3 0/5] patch description here
>
> [PATCH net] some-patch-description
>
> in subject lines. Maybe we can just encourage that format in general.
>
> And yes, I agree, for when the targets are obvious, this clearly isn't
> needed. And often they are.
>
> So this would still likely be the exception rather than the rule, but
> it would be a lot more obvious than hiding a one-liner commentary deep
> in the middle of the email.
At least for me (as the wireless-drivers maintainer) this would be a
major improvement as it's not always clear to which to tree a patch
should be applied and it would save unnecessary ping pong when I need to
ask which tree is the patch going to. I think few times I have even
accidentally applied a patch which Dave has already applied to the net tree
because of the target tree was not clearly marked.
So at least I would very much welcome having this documented somewhere
in Documentation so that I can start convincing people to use it more :)
--
Kalle Valo
prev parent reply other threads:[~2018-03-05 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 22:59 [RESEND][PATCH] bug: Exclude non-BUG/WARN exceptions from report_bug() Kees Cook
2018-03-02 18:53 ` Linus Torvalds
2018-03-02 20:22 ` Kees Cook
2018-03-02 21:23 ` Linus Torvalds
2018-03-05 5:52 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7vn9ii0.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).