From: Michael Ellerman <mpe@ellerman.id.au>
To: "Shilpasri G Bhat" <shilpa.bhat@linux.vnet.ibm.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Paul Mackerras" <paulus@samba.org>
Cc: linux-hwmon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, svaidy@linux.vnet.ibm.com,
ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com,
andrew@aj.id.au
Subject: Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors
Date: Sat, 22 Apr 2017 16:11:56 +1000 [thread overview]
Message-ID: <87a879ynrn.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <66e927c1-ceec-679d-8eaf-c6686b24b3a7@linux.vnet.ibm.com>
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
> On 04/21/2017 05:17 PM, Cédric Le Goater wrote:
>> On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote:
>>> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
>>> index 6d2e660..1f329fa8 100644
>>> --- a/drivers/hwmon/ibmpowernv.c
>>> +++ b/drivers/hwmon/ibmpowernv.c
>>> @@ -65,7 +66,8 @@ enum sensors {
>>> {"fan", "ibm,opal-sensor-cooling-fan"},
>>> {"temp", "ibm,opal-sensor-amb-temp"},
>>> {"in", "ibm,opal-sensor-power-supply"},
>>> - {"power", "ibm,opal-sensor-power"}
>>> + {"power", "ibm,opal-sensor-power"},
>>> + {"curr"}, /* Follows newer device tree compatible ibm,opal-sensor */
>>
>> why isn't there a compatible string ?
>
> Skiboot exports "ibm,opal-sensor" as compatible string for all the inband
> sensors. Now if I define that as the compatible string here, then all the
> sensors would get identified as "curr" type of sensor by the driver.
So fix it in skiboot?
cheers
next prev parent reply other threads:[~2017-04-22 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 4:31 [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors Shilpasri G Bhat
2017-04-21 11:47 ` Cédric Le Goater
2017-04-21 12:39 ` Shilpasri G Bhat
2017-04-22 6:11 ` Michael Ellerman [this message]
2017-04-25 14:28 ` Cédric Le Goater
2017-04-25 14:32 ` Cédric Le Goater
2017-04-25 14:34 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a879ynrn.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=ego@linux.vnet.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).