From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355AbdARBMV (ORCPT ); Tue, 17 Jan 2017 20:12:21 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:51156 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbdARBMU (ORCPT ); Tue, 17 Jan 2017 20:12:20 -0500 From: Vivien Didelot To: Russell King - ARM Linux , Andrew Lunn Cc: Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include In-Reply-To: <20170118001403.GJ27312@n2100.armlinux.org.uk> References: <20170118001403.GJ27312@n2100.armlinux.org.uk> Date: Tue, 17 Jan 2017 20:11:51 -0500 Message-ID: <87a8ap18a0.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, Russell King - ARM Linux writes: > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the include itself only wants the declaration of a couple of > structures and IFNAMSIZ. > > Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to > mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h > and phy_fixed.h from net/dsa.h. > > This patch reduces from around 800 files rebuilt to around 40 - even > with ccache, the time difference is noticable. > > Signed-off-by: Russell King This patch applies cleanly on net-next and builds correctly after touching include/linux/phy.h. My boards work fine with it. Tested-by: Vivien Didelot Thanks, Vivien